Repository navigation
Conversation
The step had no condition, so it ran on pull_request, merge_group, and the main run that commits the version bump. A block passes build:release here, and block-tools software build uploads binaries in that build. A PR run with a changeset version uploads the binaries of a version that is not released yet. When the PR changes its bump, that version stays in the registry. The later release finds the file, skips the upload with a warning, and ships the old binaries. clonotype-clustering: PR #156 run 39406490270 uploaded software 4.3.0 from 4.2.1 code. Release 4.3.0 (PR #163) skipped the upload and shipped those files. Use the condition of the npm pack step: main, with no version-bump changes left.
|
Automatic reviews are disabled for this repository. Configure in Code Review Settings. |
Contributor
Author
|
Replaced by #244, which targets v4 directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Run build (before publish)innode-simple-pnpm.yamlhas no condition. It runs onpull_request,merge_group, and the main run that commits the version bump. A block passesbuild-before-publish-script-name: build:release, which is the default of the block-tools template since platforma83298ed6a7. Since MILAB-6497,block-tools software builduploads the binaries in that build whenPL_BUILD_LOCATION=remote. Before that, the upload ran inprepublishOnly, only atnpm publish.PR runs also apply
changeset version, so a PR run uploads the binaries of the next release version. When the PR changes its bump or closes, that version stays in the registry. The release that later gets the version finds the file.package-builder-libcore.tslogsalready exists … Upload was skipped, and the step stays green. The release then ships the old binaries.Incident: clonotype-clustering 4.3.0
software: minor. The run computed 4.2.1 → 4.3.0 and uploaded…/4.3.0.tgzwith the 4.2.x scripts. The PR then switched topatchand released 4.2.2.software: minorgave 4.2.3 → 4.3.0. Turbo cache miss: the build ran, and all four uploads were skipped asalready exists.d25cdc827d826de1), and the release shipped descriptors for the old files.The
process-results/4.3.0.tgzonbin.pl-open.sciencehas file dates of Oct 20 12:44 CEST, and its content is identical to 4.2.3. clonotype-clustering#164 worked around it with 4.3.1.Change
The step now uses the condition of
Pack unpublished npm packages:Run build(build-script-name)Run build (before publish)pull_requestmerge_group(gh-readonly-queue/…)pushmain, version bump pending (has-changes == '1')pushmain, nothing to bump (has-changes == '0')Tradeoff
PR runs no longer run the release-channel build. A failure that only
build:releaseshows appears first on main.build-script-name(build:dev-localfor blocks) still builds the whole workspace on every PR.Not in this PR
block-toolsrun-build.tsdoes not passfailExistingfor the release channel, so a taken slot is a warning and not an error.Check
actionlintreports no new findings: the same 20 findings asv4-beta, all from earlier code.