fix(media): resolve the 17 review findings from #313

[jlocala1]

Closes #323.

All 17 verified findings from the #313 Copilot review threads (each thread has a confirmation reply; the deferral-to-follow-up was agreed there). Four commits, grouped by root cause:

1. ae6ff78 — silence-newline blindness + filler double-count (findings 3–7, 16). A shared isSilenceType() helper, swept everywhere the code tested only 'silence': stats word/silence counts, splitSilence (newline silences are the longest gaps — the ones most worth splitting — and were the only ones you couldn't), WordEditorModal's flow gate, filler matchCounts pollution, clipboard copy of [10.2s] chips. Also fixes the filler double-count: default fillers were incremented in both the DEFAULT loop and the unconditional custom-word set, so UI counts (and "time saved") were exactly 2×.

2. b5b5471 — edit-state correctness (findings 1, 2, 13). The worst bug of the set: threshold rebuild saved deletions keyed by position in the old silence-inserted array but restored them by non-silence word ordinal — mismatched keyspaces, so changing silence thresholds after deleting words silently moved deletions onto the wrong words. Both phases now key by word ordinal. Plus: hasEdits stuck true after undo-to-baseline (compared against raw transcript.words length instead of the silence-inserted baseline), and the hasEdits initializer missing saved text-only edits (incl. ScriptPanel applies).

3. 1ecd1e7 — refs, perf, a11y, packaging (findings 8, 10, 12, 15, 17, 18, 9, 14). MediaPlayer error now clears on src change (it previously unmounted the media element and never retried a corrected src); external playerRef is a stable delegating proxy instead of a []-deps first-commit snapshot that could hold a stale handle forever; getSpeedAtIndex stops re-sorting already-sorted markers per call; originalIndex doc corrected (it indexes the silence-inserted timeline, not transcript.words — the confusion behind two other threads); segment rows drop the custom Enter/Space handlers on the native-<button> path (double-invocation); ScriptPanel's parseScript whitelists wordType values instead of casting arbitrary strings into the union; 22 missing opacity-modifier classes added to miewebUISafelist (MediaEditor + TranscriptView sweep).

4. c411f24 — regression tests. Six new tests covering the behavioral findings; checked each one against the pre-fix code — all six fail there, then pass with the fixes. (The existing 53 media tests caught none of these — that gap is why every fix ships with a test.)

Verification: pnpm format / pnpm lint / pnpm typecheck (the Lint job's three commands) all exit 0; 59/59 media tests pass (53 existing + 6 new).

[Copilot]

Pull request overview

This PR addresses the set of verified follow-up fixes from #313 (tracked in #323) across the media editing stack, focusing on correctness (silence handling + edit state), stability of refs/error recovery, performance, Tailwind safelisting, and adding regressions to lock behavior in.

Changes:

• Introduces and adopts a shared isSilenceType() helper to correctly handle both silence and silence-newline across editing logic and stats.
• Fixes edit-state correctness issues (including hasEdits baseline comparisons and deletion preservation across silence-threshold rebuilds) and improves getSpeedAtIndex performance by removing per-call sorts.
• Adds targeted regression tests for the previously verified findings and expands the Tailwind safelist for media-stack classes.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/tailwind-preset.ts	Adds Tailwind safelist entries needed by the media components’ opacity/state variants.
src/hooks/useTranscriptEdits.ts	Fixes silence handling, edit-state baseline comparisons, threshold rebuild deletion preservation, and removes per-call marker sorting.
src/hooks/useTranscriptEdits.test.ts	Adds regression tests covering the verified findings/fixes.
src/components/TranscriptView/TranscriptView.tsx	Uses native <button> click handling for segment rows to avoid redundant activation handling.
src/components/TranscriptView/transcript.ts	Adds isSilenceType() helper and corrects EditableWord.originalIndex documentation.
src/components/MediaPlayer/MediaPlayer.tsx	Clears sticky error state when src changes to allow retry with corrected URLs.
src/components/MediaEditor/WordEditorModal.tsx	Uses isSilenceType() so newline silences are treated as silences in the modal flow.
src/components/MediaEditor/ScriptPanel.tsx	Validates wordType values instead of accepting arbitrary strings into the union.
src/components/MediaEditor/MediaEditor.tsx	Fixes external playerRef to be a stable delegating proxy and updates silence filtering to include silence-newline.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

src/hooks/useTranscriptEdits.ts:150

• getSpeedAtIndex is exported via src/hooks/index.ts, but it now assumes speedMarkers are sorted and breaks early. If a library consumer passes an unsorted marker array (which previously worked because this function sorted defensively), the effective speed can become incorrect.

  // Markers are kept sorted at insert (toggleSpeedMarker) — scanning without
  // a per-call copy+sort matters because stats calls this once per word.
  let effectiveSpeed = defaultSpeed;
  for (const marker of speedMarkers) {
    if (marker.wordIndex <= wordIndex) {
      effectiveSpeed = marker.speed;
    } else {
      break;
    }
  }

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/hooks/useTranscriptEdits.test.ts:328

• This test title references “#327 review”, but the surrounding regression suite is for ui#323; consider updating the reference to avoid confusion when mapping tests to the originating issue/review thread.

  it('drops stale undo snapshots on a threshold rebuild (#327 review)', () => {

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

src/hooks/useTranscriptEdits.test.ts:121

• The test name references "#327 review", but this PR/issue context is ui#323. This mismatch makes it harder to trace the regression back to the right thread/issue.

  it('is order-independent for external callers (#327 review)', () => {

src/hooks/useTranscriptEdits.test.ts:346

• This test description references "#327 review", but the suite targets ui#323 regressions. Consider updating the reference to match the PR/issue being closed.

  it('keeps deletions on the right words across a threshold rebuild with pasted words (#327 review)', () => {

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.