Skip to content

Remove unused variant headers for warning-free 2.2.2 builds - #254

Merged
bob sira (bobsira) merged 3 commits into
mainfrom
version2.2.2-rc
Nov 16, 2026
Merged

bob sira (bobsira) merged 3 commits into
mainfrom
version2.2.2-rc

Conversation

@bobsira

Copy link
Copy Markdown
Contributor

Summary

Remove three unused <variant> includes from the production/test precompiled headers and ConfigFileParser.h.

The native Visual Studio builds use C++14, so these unused C++17 headers produce STL4038 warnings. Removing them restores warning-free builds without changing the language standard, suppressing diagnostics, or changing runtime behavior.

This is the remaining source cleanup for the final v2.2.2 release. The release branch incorporates the already-merged shutdown fix (#250) and embedded-NUL process-output fix (#253); the diff against main contains only the three include deletions. The existing RC tags and published assets are unchanged.

Validation

Clean Release build Compiler warnings Full test suite
Native x64 0 51/51 passed
Native x86 0 51/51 passed
CMake x64 0 51/51 passed
  • Suites ran sequentially, with no test retries.
  • Repository-wide cpplint 2.0.2 passed all 35 tracked C++ source/header files.
  • Whitespace checks passed.
  • Both native executables retain file/product version 2.2.2.

The final release will use a fresh, verified Azure build and Microsoft-signed x64 artifact after review and merge, not a republished RC2 executable.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The unused-header cleanup has no active review issues blocking approval.

No open issues 🎉

What changed in this PR

Removes unused C++17 <variant> headers from Log Monitor’s C++14 builds to eliminate STL4038 warnings for the final v2.2.2 release. This cleanup leaves runtime behavior unchanged and does not modify the previously merged shutdown or process-output fixes.

Changes:

  • Remove three unused includes from production, parser, and test headers.
  • Preserve the language standard, diagnostic settings, versioning, and published release artifacts.
File Description
LogMonitor/​src/​LogMonitor/​pch.h Removes the unused <variant> include from the production precompiled header.
LogMonitor/​src/​LogMonitor/​Parser/​ConfigFileParser.h Removes the unused <variant> include from the parser header.
LogMonitor/​LogMonitorTests/​pch.h Removes the unused <variant> include from the test precompiled header.

Review effort: Max

@bobsira
bob sira (bobsira) merged commit 84f0687 into main Nov 16, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants