Repository navigation
Remove unused variant headers for warning-free 2.2.2 builds - #254
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The unused-header cleanup has no active review issues blocking approval.
No open issues 🎉
What changed in this PR
Removes unused C++17 <variant> headers from Log Monitor’s C++14 builds to eliminate STL4038 warnings for the final v2.2.2 release. This cleanup leaves runtime behavior unchanged and does not modify the previously merged shutdown or process-output fixes.
Changes:
- Remove three unused includes from production, parser, and test headers.
- Preserve the language standard, diagnostic settings, versioning, and published release artifacts.
| File | Description |
|---|---|
LogMonitor/src/LogMonitor/pch.h |
Removes the unused <variant> include from the production precompiled header. |
LogMonitor/src/LogMonitor/Parser/ConfigFileParser.h |
Removes the unused <variant> include from the parser header. |
LogMonitor/LogMonitorTests/pch.h |
Removes the unused <variant> include from the test precompiled header. |
Review effort: Max
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove three unused
<variant>includes from the production/test precompiled headers andConfigFileParser.h.The native Visual Studio builds use C++14, so these unused C++17 headers produce
STL4038warnings. Removing them restores warning-free builds without changing the language standard, suppressing diagnostics, or changing runtime behavior.This is the remaining source cleanup for the final v2.2.2 release. The release branch incorporates the already-merged shutdown fix (#250) and embedded-NUL process-output fix (#253); the diff against
maincontains only the three include deletions. The existing RC tags and published assets are unchanged.Validation
The final release will use a fresh, verified Azure build and Microsoft-signed x64 artifact after review and merge, not a republished RC2 executable.