Issue Type & Label Group by#8587
Open
epjonnadula wants to merge 2 commits into
Open
Conversation
Author
|
@microsoft-github-policy-service agree |
AguilarFile
reviewed
Apr 17, 2026
| commentCount: number; | ||
| reactionCount: number; | ||
| reactions: Reaction[]; | ||
| issueType?: string; |
alexr00
requested changes
Jul 15, 2026
Comment on lines
+271
to
+281
| } else { | ||
| const groupsTemp = groupBy(issues, issue => { | ||
| if (groupByValue === 'repository') { | ||
| return `${issue.remote.owner}/${issue.remote.repositoryName}`; | ||
| } else if (groupByValue === 'milestone') { | ||
| return issue.milestone?.title ?? 'No Milestone'; | ||
| } | ||
| return 'Other'; | ||
| }); | ||
| Object.assign(groups, groupsTemp); | ||
| } |
Member
There was a problem hiding this comment.
For consistency and readability, we should have all the groupByValues checked in the same if, not have the last 2 checked in an else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.