Fix PR runs on forks - #346
Merged
John Stairs (johnstairs) merged 7 commits intoSep 17, 2026
Merged
Conversation
Copilot started reviewing on behalf of
John Stairs (johnstairs)
September 16, 2026 19:31
View session
There was a problem hiding this comment.
🔵 Needs a closer look
Unresolved workflow dependency and Dependabot detection issues affect intended PR checks.
Pull request overview
Updates PR CI to support forked and Dependabot PRs without unavailable secrets or GHCR publishing.
Changes:
- Selects GitHub or managed-identity authentication.
- Skips GHCR publishing for fork and Dependabot PRs.
- Adjusts image, binary, and private-link job dependencies.
File summaries
| File | Summary |
|---|---|
.github/workflows/pr-ci.yml |
Updates authentication, publishing conditions, and CI job dependencies. |
Review details
Suppressed comments (2)
.github/workflows/pr-ci.yml:219
- This condition skips
publish-ghcrfor fork and Dependabot PRs, butverify-binariesstill lists that job in itsneedsat lines 600–606. GitHub skips a job when one of its required jobs is skipped, so the binary-install verification (and any required check based on it) will also be skipped for the PRs this change is intended to support. Removepublish-ghcrfromverify-binaries.needsor otherwise make that dependency non-blocking for these PRs.
if: github.actor != 'dependabot[bot]' && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
.github/workflows/pr-ci.yml:219
github.actoris the user who triggered or re-ran the workflow, not necessarily the pull request author. If a maintainer re-runs a Dependabot PR, this predicate can become true, and the job will attempt to publish with the unavailable Dependabot-PR credentials; checkgithub.event.pull_request.user.login(and the event type) instead when excluding Dependabot PRs.
if: github.actor != 'dependabot[bot]' && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Yulia Dubinina (yuliadub)
approved these changes
Sep 16, 2026
John Stairs (johnstairs)
merged commit Sep 17, 2026
d9fe00b
into
microsoft:main
37 of 38 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub action runs on PRs from forks were not working because they do not have the same permissions. Specifically, we skip publishing to
ghcr.ioand we use managed identity for Tyger authentication because theACTIONS_ID_TOKEN_REQUEST_URLandACTIONS_ID_TOKEN_REQUEST_TOKENenvironment variables, which allow FIC/OIDC flows, are not available.