Skip to content

Fix PR runs on forks - #346

Merged
John Stairs (johnstairs) merged 7 commits into
microsoft:mainfrom
johnstairs:johnstairs/fix-fork-ci
Sep 17, 2026
Merged

John Stairs (johnstairs) merged 7 commits into
microsoft:mainfrom
johnstairs:johnstairs/fix-fork-ci

Conversation

@johnstairs

@johnstairs John Stairs (johnstairs) commented Sep 16, 2026

Copy link
Copy Markdown
Member

GitHub action runs on PRs from forks were not working because they do not have the same permissions. Specifically, we skip publishing to ghcr.io and we use managed identity for Tyger authentication because the ACTIONS_ID_TOKEN_REQUEST_URL and ACTIONS_ID_TOKEN_REQUEST_TOKEN environment variables, which allow FIC/OIDC flows, are not available.

@johnstairs John Stairs (johnstairs) changed the title [Draft] fork test Fix PR runs on forks Sep 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Unresolved workflow dependency and Dependabot detection issues affect intended PR checks.

Pull request overview

Updates PR CI to support forked and Dependabot PRs without unavailable secrets or GHCR publishing.

Changes:

  • Selects GitHub or managed-identity authentication.
  • Skips GHCR publishing for fork and Dependabot PRs.
  • Adjusts image, binary, and private-link job dependencies.
File summaries
File Summary
.github/workflows/pr-ci.yml Updates authentication, publishing conditions, and CI job dependencies.
Review details

Suppressed comments (2)

.github/workflows/pr-ci.yml:219

  • This condition skips publish-ghcr for fork and Dependabot PRs, but verify-binaries still lists that job in its needs at lines 600–606. GitHub skips a job when one of its required jobs is skipped, so the binary-install verification (and any required check based on it) will also be skipped for the PRs this change is intended to support. Remove publish-ghcr from verify-binaries.needs or otherwise make that dependency non-blocking for these PRs.
    if: github.actor != 'dependabot[bot]' && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)

.github/workflows/pr-ci.yml:219

  • github.actor is the user who triggered or re-ran the workflow, not necessarily the pull request author. If a maintainer re-runs a Dependabot PR, this predicate can become true, and the job will attempt to publish with the unavailable Dependabot-PR credentials; check github.event.pull_request.user.login (and the event type) instead when excluding Dependabot PRs.
    if: github.actor != 'dependabot[bot]' && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/pr-ci.yml Outdated
Comment thread .github/workflows/pr-ci.yml
@johnstairs
John Stairs (johnstairs) merged commit d9fe00b into microsoft:main Sep 17, 2026
37 of 38 checks passed
@johnstairs
John Stairs (johnstairs) deleted the johnstairs/fix-fork-ci branch September 17, 2026 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants