[main] Update dependencies from devdiv/DevDiv/vs-code-coverage, dotnet/arcade - #10565
Open
dotnet-maestro[bot] wants to merge 2 commits into
Open
[main] Update dependencies from devdiv/DevDiv/vs-code-coverage, dotnet/arcade#10565dotnet-maestro[bot] wants to merge 2 commits into
dotnet-maestro[bot] wants to merge 2 commits into
Conversation
…811.2 On relative base path root Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.XliffTasks From Version 11.0.0-beta.26410.10 -> To Version 11.0.0-beta.26411.2
![microsoft-github-policy-service[bot]](https://avatars.githubusercontent.com/in/95686?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Updates the Arcade toolset and extends Helix job monitoring to optionally control per-test result attachments, alongside a reliability fix in the GitHub App installation lookup script.
Changes:
- Bumped
Microsoft.DotNet.Arcade.Sdk/ templating toolset versions to11.0.0-beta.26411.2(and updated SHAs). - Added
testResultAttachmentModeparameter to the Helix job monitor template and forwarded it to the monitoring tool. - Fixed PowerShell GitHub App installation enumeration and added deterministic handling for multiple matching installations.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| global.json | Updates Arcade SDK version used by the repo toolset. |
| eng/common/core-templates/job/helix-job-monitor.yml | Adds a new parameter and forwards it as a CLI flag to control test result attachments. |
| eng/common/Get-GitHubAppToken.ps1 | Fixes handling of top-level JSON arrays and adds explicit validation for multiple installation matches. |
| eng/Versions.props | Aligns templating package version with updated Arcade toolset. |
| eng/Version.Details.xml | Updates Arcade dependency versions and SHAs to match the toolset bump. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| organization='${{ parameters.organization }}' | ||
| repository='${{ parameters.repository }}' | ||
| testResultAttachmentMode='${{ parameters.testResultAttachmentMode }}' |
Comment on lines
+245
to
+247
| if [ -n "$testResultAttachmentMode" ]; then | ||
| toolArgs+=( --test-result-attachment-mode "$testResultAttachmentMode" ) | ||
| fi |
| exit 1 | ||
| } | ||
| $installation = $matchingInstallations[0] | ||
| Write-Host "Using installation $($installation.id) for '$($installation.account.login)'." |
…code-coverage build 20260811.4 On relative base path root Microsoft.Testing.Extensions.CodeCoverage From Version 18.11.0-preview.26410.2 -> To Version 18.11.0-preview.26411.4
dotnet-maestro
Bot
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Suppressed comments (2)
eng/common/core-templates/job/helix-job-monitor.yml:247
- The
testResultAttachmentModeparameter has an explicit default (Failed) and a constrainedvalues:list, so it will always be non-empty for valid template invocations. The-nconditional is therefore redundant and adds branching that can drift over time. Consider always appending--test-result-attachment-modeunconditionally (or, if you want an escape hatch, make it explicit via an additional boolean likeenableTestResultAttachmentsArg).
if [ -n "$organization" ]; then toolArgs+=( --organization "$organization" ); fi
if [ -n "$repository" ]; then toolArgs+=( --repository "$repository" ); fi
if [ -n "$testResultAttachmentMode" ]; then
toolArgs+=( --test-result-attachment-mode "$testResultAttachmentMode" )
fi
eng/common/Get-GitHubAppToken.ps1:143
Write-Hostis hard to control/redirect in automation and can add noise to stdout for callers. PreferWrite-Verbose(with-Verboseopt-in) orWrite-Informationso pipeline consumers can suppress or route it without affecting standard output.
Write-Host "Using installation $($installation.id) for '$($installation.account.login)'."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
From https://dev.azure.com/devdiv/DevDiv/_git/vs-code-coverage