Repository navigation
Fix neutral atom simulation mutating caller's NoiseConfig - #4218
Open
Anshika Grover (anshikagrover15) wants to merge 1 commit into
Open
Anshika Grover (anshikagrover15) wants to merge 1 commit into
Anshika Grover (anshikagrover15) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
Anshika Grover (anshikagrover15)
marked this pull request as ready for review
November 8, 2026 10:55
Anshika Grover (anshikagrover15)
requested review from
Bill Ticehurst (billti) and
Ian Davis (idavis)
as code owners
November 8, 2026 10:55
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4094.
NoiseConfig.copy()to create an independent copy of gate-noise tables.intrinsicsto avoid duplicating the potentially large table.NeutralAtomDevice.simulate()to apply RZ noise inheritance to a copy instead of modifying the caller's configuration.Testing
git diff --check: passed.