Repository navigation
fix: allow closing a context more than once - #354
Open
Patrick Hintermayer (patrick-immometrica) wants to merge 1 commit into
Open
Patrick Hintermayer (patrick-immometrica) wants to merge 1 commit into
Patrick Hintermayer (patrick-immometrica) wants to merge 1 commit into
Conversation
Patrick Hintermayer (patrick-immometrica)
marked this pull request as ready for review
November 21, 2026 11:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
close()twice on a context is fine in Playwright, but with the plugin the second call fails the test:It comes from the close wrapper in
new_context. A second call now skips the bookkeeping and goes straight to the originalclose(). Test added for sync and async.