Repository navigation
fix: send launch options to remote browsers with protocol option names - #349
Merged
Merged
Conversation
Pavel Feldman (pavelfeldman)
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When `connect_options` is set, the launch options are sent to the server as JSON in the `x-playwright-launch-options` header. The server reads them with the protocol option names (`slowMo`, `firefoxUserPrefs`, `chromiumSandbox`, ...), but the plugin sent the Python names (`slow_mo`, ...), so every multi-word option was silently ignored. In particular `--slowmo` had no effect on remote browsers.
The option names are now converted to camelCase before they are sent, in both the sync and the asyncio plugin. Only the top-level names are converted; values such as `firefox_user_prefs` are passed as is.
`test_connect_options_should_work` now also runs with `--slowmo` against the server and checks that the clicks are slowed down, for both plugins. The tests fail without the fix.
Supersedes #348, which converts `slow_mo` only.