Resolve Dependabot alerts (cmov, postcss, react-router) - #4087
Open
benhillis wants to merge 1 commit into
Open
Conversation
Address three open Dependabot security alerts: - cmov 0.5.3 -> 0.5.4 (GHSA-3rjw-m598-pq24) in Cargo.lock - postcss 8.5.15 -> 8.5.25 (GHSA-r28c-9q8g-f849) in petri/logview - react-router 7.18.0 -> 8.3.0 (GHSA-qwww-vcr4-c8h2) in petri/logview react-router v8 merged the separate react-router-dom package (which stopped at 7.18.2, within the vulnerable range) into react-router, so migrate the logview app off react-router-dom by updating package.json and switching all import sites to "react-router". The APIs used (Link, useParams, useSearchParams, useLocation, useNavigate, HashRouter, Routes, Route, Navigate) are unchanged in v8. Also fix a stale .gitignore entry (logview_new/dist* -> logview/dist*) so the Vite build output stays ignored. Verified with `npm audit` (0 vulnerabilities) and `vite build`. Co-authored-by: Copilot <[email protected]> Copilot-Session: d6a7eb95-877c-4daa-a2f5-33c0f14d50f9
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Rust and Node dependencies to remediate three Dependabot security alerts, including migrating Petri Logview from react-router-dom to react-router v8.
Changes:
- Bump Rust dependency
cmovinCargo.lockto address GHSA-3rjw-m598-pq24. - Update
postcss(and related lockfile entries) and migrate routing imports/dependency toreact-router@^8.3.0. - Fix stale
.gitignorepattern so Logview Vite build output remains ignored.
Reviewed changes
Copilot reviewed 14 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
petri/logview/src/tests.tsx |
Switch routing imports from react-router-dom to react-router. |
petri/logview/src/test_details.tsx |
Switch routing imports from react-router-dom to react-router. |
petri/logview/src/table_defs/tests.tsx |
Switch Link import to react-router. |
petri/logview/src/table_defs/test_details.tsx |
Switch Link import to react-router. |
petri/logview/src/table_defs/runs.tsx |
Switch Link import to react-router. |
petri/logview/src/table_defs/run_details.tsx |
Switch Link import to react-router. |
petri/logview/src/search.tsx |
Switch navigation hook imports to react-router. |
petri/logview/src/runs.tsx |
Switch routing imports from react-router-dom to react-router. |
petri/logview/src/run_details.tsx |
Switch routing imports from react-router-dom to react-router. |
petri/logview/src/menu.tsx |
Switch Link import to react-router. |
petri/logview/src/main.tsx |
Switch router component imports (HashRouter, Routes, etc.) to react-router. |
petri/logview/src/log_viewer.tsx |
Switch routing imports from react-router-dom to react-router. |
petri/logview/src/docs/docs.tsx |
Switch Link import to react-router. |
petri/logview/package.json |
Replace react-router-dom with react-router@^8.3.0. |
petri/logview/package-lock.json |
Lockfile updates for react-router v8 and postcss update, including dependency graph changes. |
Cargo.lock |
Update cmov 0.5.3 → 0.5.4. |
.gitignore |
Update ignored Logview build output path (logview_new → logview). |
Files not reviewed (1)
- petri/logview/package-lock.json: Generated file
Comment on lines
6
to
+8
| "react": "^19.2.1", | ||
| "react-dom": "^19.2.1", | ||
| "react-router-dom": "7.18.0" | ||
| "react-router": "^8.3.0" |
Comment on lines
1725
to
1727
| "engines": { | ||
| "node": ">=20.0.0" | ||
| "node": ">=22.22.0" | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the three open Dependabot security alerts.
cmov(Cargo.lock)postcss(petri/logview)react-router(petri/logview)react-router migration
react-router v8 merged the separate
react-router-dompackage intoreact-router.react-router-domstopped at 7.18.2 (still within the vulnerable range), so the fix requires moving toreact-routerv8. This PR:react-router-domdependency withreact-router@^8.3.0inpackage.json.react-router-domtoreact-router.The APIs used (
Link,useParams,useSearchParams,useLocation,useNavigate,HashRouter,Routes,Route,Navigate) are unchanged in v8.Misc
.gitignoreentry (logview_new/dist*→logview/dist*) so the Vite build output stays ignored.Verification
npm audit→ 0 vulnerabilitiesvite build→ succeeds