Document npm lockfile regeneration for external contributors - #245
Merged
Jackson Weber (JacksonWeber) merged 3 commits intoSep 16, 2026
Merged
Jackson Weber (JacksonWeber) merged 3 commits into
Jackson Weber (JacksonWeber) merged 3 commits into
Conversation
Co-authored-by: Copilot App <[email protected]>
Jackson Weber (JacksonWeber)
requested a review
from Hector Hernandez (hectorhdzg)
as a code owner
September 16, 2026 19:56
Jackson Weber (JacksonWeber)
requested review from
Nev (MSNev),
Jeremy Voss (jeremydvoss),
Leighton Chen (lzchen) and
Radhika Gupta (rads-1996)
as code owners
September 16, 2026 19:56
Copilot started reviewing on behalf of
Jackson Weber (JacksonWeber)
September 16, 2026 19:57
View session
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Sample projects remain tied to internal-feed lockfile URLs unless the policy scope is clarified or extended.
Pull request overview
This PR makes the root npm lockfile registry-neutral while preserving dependency versions, integrity hashes, and relationships.
Changes:
- Adds registry-neutral npm configuration.
- Removes 486 registry-specific
resolvedfields. - Documents installation and lockfile update behavior.
File summaries
| File | Summary |
|---|---|
package-lock.json |
Removes registry resolution URLs while preserving locked metadata. |
CONTRIBUTING.md |
Documents registry-neutral installation and update workflows. |
.npmrc |
Enables registry-neutral lockfile generation. Moderate finding (1 vote): sample projects remain tied to internal-feed URLs. |
Review details
Suppressed comments (1)
.npmrc:1
- This setting only affects the repository-root npm project. The documented sample projects have separate package roots and committed lockfiles (
samples/package.jsonandsamples/aks-langchain/package.json), and those lockfiles still containresolvedURLs toms-feed-*.pkgs.visualstudio.com(for example,samples/aks-langchain/package-lock.json:21). Runningnpm install/npm ciin a sample therefore remains tied to the internal feed, so either apply the registry-neutral policy to those projects too or clarify that this change covers only the root package.
omit-lockfile-registry-resolved=true
- Files reviewed: 2/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <[email protected]>
Co-authored-by: Copilot App <[email protected]>
Radhika Gupta (rads-1996)
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The earlier registry-neutral configuration experiment has been removed. The final change retains the existing Microsoft-feed lockfile without modifying dependency versions, integrity hashes, package.json, or npm configuration.
Validation
git diff --check.