Skip to content

fix(a365): default InvokeAgent spans to internal #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Nikhil Navakiran (nikhilNava) wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix(a365): default InvokeAgent spans to internal #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42bcfe2
fix(a365): default invoke agent spans to internal
nikhilc-microsoft Sep 14, 2026
ed097f5
docs: link InvokeAgent span-kind changelog entry
nikhilc-microsoft Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## [Unreleased]

### Bugs Fixed
- Default `InvokeAgentScope` spans to `SpanKind.INTERNAL` while preserving explicit span-kind overrides. [#241](https://github.com/microsoft/opentelemetry-distro-javascript/pull/241)

### Other Changes
- Consolidate Dependabot updates for Vitest 4.1.11, Hono 4.13.7, qs 6.16.0, fast-uri 3.1.7, actions/deploy-pages 5.0.1, and actions/checkout 7.0.1.

Expand Down
5 changes: 3 additions & 2 deletions src/a365/scopes/InvokeAgentScope.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ export class InvokeAgentScope extends OpenTelemetryScope {
* @param invokeScopeDetails Scope-level details (endpoint).
* @param agentDetails The agent identity. `tenantId` is required.
* @param callerDetails Optional caller information (human, agent, or both for A2A).
* @param spanDetails Optional span configuration.
* @param spanDetails Optional span configuration. Defaults the span kind to
* `SpanKind.INTERNAL` when omitted.
*/
public static start(
request: Request,
Expand Down Expand Up @@ -56,7 +57,7 @@ export class InvokeAgentScope extends OpenTelemetryScope {

const resolvedSpanDetails: SpanDetails = {
...spanDetails,
spanKind: spanDetails?.spanKind ?? SpanKind.CLIENT,
spanKind: spanDetails?.spanKind ?? SpanKind.INTERNAL,
};

super(
Expand Down
4 changes: 2 additions & 2 deletions test/internal/unit/a365/scopes.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -990,8 +990,8 @@ describe("Scopes", () => {
});

it.each([
["CLIENT (default)", undefined, SpanKind.CLIENT],
["SERVER", SpanKind.SERVER, SpanKind.SERVER],
["INTERNAL (default)", undefined, SpanKind.INTERNAL],
["SERVER (override)", SpanKind.SERVER, SpanKind.SERVER],
])("InvokeAgentScope spanKind: %s", (_label, input, expected) => {
const scope = InvokeAgentScope.start(
testRequest,
Expand Down
Loading