feat(a365): add InvokeAgent GenAI parameters - #239
Merged
Nikhil Navakiran (nikhilNava) merged 4 commits intoSep 16, 2026
Merged
Conversation
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]> Copilot-Session: 9ccc29b9-bf5d-4725-be3b-c4276b233c4c
Co-authored-by: Copilot <[email protected]> Copilot-Session: 9ccc29b9-bf5d-4725-be3b-c4276b233c4c
Nikhil Navakiran (nikhilNava)
marked this pull request as ready for review
September 15, 2026 22:11
Nikhil Navakiran (nikhilNava)
requested review from
Jackson Weber (JacksonWeber),
Nev (MSNev),
ajmfehr,
Pujarini Mohapatra (biswapm),
Grant Harris (gwharris7),
Hector Hernandez (hectorhdzg),
Jeremy Voss (jeremydvoss),
Julio Carlos Menendez (juliomenendez),
Leighton Chen (lzchen) and
Radhika Gupta (rads-1996)
as code owners
September 15, 2026 22:11
Copilot started reviewing on behalf of
Nikhil Navakiran (nikhilNava)
September 15, 2026 22:12
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
All changes are reviewed; only a non-blocking JSDoc nit remains.
Pull request overview
Adds reusable GenAI contracts and OpenTelemetry v1.42 attribute emission for manual A365 InvokeAgent telemetry.
Changes:
- Added GenAI request/response contracts and public exports.
- Added request, response, cache-token, and provider attributes.
- Added tests, documentation, and changelog coverage.
File summaries
| File | Summary |
|---|---|
test/internal/unit/a365/scopes.test.ts |
Tests attribute emission and provider behavior. |
test/internal/unit/a365/invokeAgentGenAiParameters.test.ts |
Tests contracts and constants. |
src/index.ts |
Exports new root-level types. |
src/a365/scopes/OpenTelemetryScope.ts |
Propagates provider identity. |
src/a365/scopes/InvokeAgentScope.ts |
Emits request/response attributes; add JSDoc for the public late-recording method. |
src/a365/index.ts |
Exports new types. |
src/a365/contracts.ts |
Defines GenAI parameter contracts. |
src/a365/constants.ts |
Adds semantic-convention keys. |
CHANGELOG.md |
Records the feature. |
A365_DOCUMENTATION.md |
Documents the new API and attributes. |
Review details
Suppressed comments (1)
src/a365/scopes/InvokeAgentScope.ts:142
- This newly public API has no JSDoc, while the other public recording methods in this scope are documented. Add a brief description stating that it records late response and usage parameters so generated API documentation explains when callers should use it.
public recordResponseParameters(responseParameters: GenAiResponseParameters): void {
this.mapResponseParameters(responseParameters);
}
- Files reviewed: 10/10 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <[email protected]> Copilot-Session: 9ccc29b9-bf5d-4725-be3b-c4276b233c4c
Hector Hernandez (hectorhdzg)
approved these changes
Sep 16, 2026
Nikhil Navakiran (nikhilNava)
deleted the
feature/a365-invoke-agent-parameters
branch
September 16, 2026 21:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Parity with microsoft/opentelemetry-distro-dotnet#120, with attribute names and structured content aligned to the current OpenTelemetry GenAI semantic conventions. ETW logger changes are out of scope.