docs: clarify FinOps hub private endpoint topology - #2270
Open
Brett Wilson (MSBrett) wants to merge 3 commits into
Open
docs: clarify FinOps hub private endpoint topology#2270Brett Wilson (MSBrett) wants to merge 3 commits into
Brett Wilson (MSBrett) wants to merge 3 commits into
Conversation
Document Toolkit ownership of the FinOps hub network and recommend customer-managed private endpoints while preserving peering, DNS, cleanup, and subnet guidance. Relates-to: microsoft#2156 Co-authored-by: Copilot App <[email protected]>
Brett Wilson (MSBrett)
requested review from
Roland Krummenacher (RolandKrummenacher) and
Michael Flanakin (flanakin)
as code owners
August 19, 2026 14:57
Contributor
There was a problem hiding this comment.
Pull request overview
Documentation-only update clarifying FinOps hub private networking ownership boundaries and recommending a customer-managed private endpoint topology, aligning guidance with the known upgrade behavior described in #2156 without changing template implementation.
Changes:
- Added explicit ownership boundary language: the Toolkit owns/manages the hub VNet, subnets, private DNS, routing, and related resources.
- Documented customer-managed private endpoints (in the customer VNet) as the preferred private-access topology; kept peering as a secondary option.
- Updated deployment guidance text and added an Unreleased changelog entry referencing #2156.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs-mslearn/toolkit/hubs/private-networking.md | Adds ownership boundary + preferred customer-managed private endpoint guidance and updates related sections (enable/disable, DNS, peering). |
| docs-mslearn/toolkit/hubs/deploy.md | Updates private routing decision guidance to point to customer-managed endpoints/DNS first, peering second. |
| docs-mslearn/toolkit/changelog.md | Adds an Unreleased FinOps hubs changelog entry capturing the documentation clarification and topology recommendation. |
Suppressed comments (3)
docs-mslearn/toolkit/hubs/private-networking.md:50
- This sentence uses "please refer to"; Microsoft style guidance typically prefers direct phrasing like "see" and avoids "please" in technical documentation.
Note that private networking incurs extra cost for networking resources, connectivity, and dedicated compute in Azure Data Factory. For a detailed cost estimate, please refer to the Azure pricing calculator.
docs-mslearn/toolkit/hubs/private-networking.md:186
- "domain name system" should be capitalized as the proper term "Domain Name System (DNS)".
Communication between the various FinOps hub components is encrypted using TLS. For TLS certificate validation to succeed when using private networking, reliable domain name system (DNS) name resolution is required. The Toolkit creates and manages DNS zones, private endpoints, and DNS entries that guarantee name resolution between FinOps hub components.
docs-mslearn/toolkit/hubs/private-networking.md:210
- The wording "one's corporate" is awkward/inconsistent with the rest of the page; use direct second-person phrasing.
- Allowing one's corporate firewall and VPN IP ranges access over the public internet via the storage and Data Explorer firewalls.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Align private-mode Data Factory guidance with the managed integration runtime and address the related terminology and style review feedback. Co-authored-by: Copilot App <[email protected]>
Co-authored-by: Copilot App <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope and issue relationship
Relates to #2156. This documentation does not fix or claim to fix the template behavior reported there. The current
devtemplate still declares the VNet's inlinesubnetscollection, so the implementation defect remains outside this documentation-only PR.This replaces closed PR #2230 with a scope-audited patch. It does not change Bicep, template reference, upgrade guidance, Power BI setup, marketing pages, or page ownership metadata.
Requirements traceability matrix
private-networking.md: How private access works and FinOps hub virtual networkprivate-networking.md: ownership boundary and VNet sectionsprivate-networking.md: Preferred option: customer-managed private endpointsfinops-hubs-customer-endpoints.pngprivate-networking.md: Network peering, routing, and name resolutionprivate-networking.md: Removing private networkingprivate-networking.md: FinOps hub virtual network/28,/28,/27,/26minimum/default, and directs Power BI VNet Data Gateway capacity to the customer VNetchangelog.md: Unreleased → FinOps hubs → Changedauthorandms.authormatchdev; no SVG source or implementation filesClosed PR #2230 feedback addressed
Validation
pwsh -NoProfile -Command './src/scripts/Test-PowerShell.ps1 -Docs -Lint -Unit'— 2,296 passed, 0 failed.git diff --check— PASS.42D181EE8DF106FB348E0C9C70D361281190DBCC618FF7C95A562BF97F057BCA(the corrected customer-endpoint diagram with the Toolkit-owned boundary enclosing Storage and Azure Data Explorer).