fix(webeval): pass the configured round limit to FaraAgent - #91
Draft
Magnus Müller (MagMueller) wants to merge 1 commit into
Draft
Magnus Müller (MagMueller) wants to merge 1 commit into
Magnus Müller (MagMueller) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy Fara-7B evaluator constructs FaraAgent with a hardcoded max_rounds value, ignoring the caller's configuration. This passes self.max_rounds instead.
The exact constructor expression was exercised with an argument recorder before and after the patch, and the patch applies to current main. No full evaluator, browser or model run was performed. PR #87 separately addresses the existing BrowserBB import path.
Fixes #59.