Repository navigation
Fix Discovery GA deployment validation and CP2K image builds - #285
Merged
Mukesh Dua (mukesh-dua) merged 9 commits intoOct 30, 2026
Merged
Mukesh Dua (mukesh-dua) merged 9 commits into
Mukesh Dua (mukesh-dua) merged 9 commits into
Conversation
Include a pinned non-root R tool image, reproducible examples and regression tests. Require real execution evidence during deployment validation, preserve diagnostics, and handle approval continuation without self-approving. Co-authored-by: Copilot <[email protected]>
Ensure clean CI environments can collect the deployment validator regression tests. Co-authored-by: Copilot <[email protected]>
Keep the exact pinned dependency assertion aligned with the deployer test dependency. Verified the full Linux Python 3.12 suite: 907 tests and 11 subtests passed. Co-authored-by: Copilot <[email protected]>
Include 2D and 3D visualization outputs, gallery examples, strict MMFF convergence checks, supported structure helper defaults, and related deployment input/approval fixes. Co-authored-by: Copilot <[email protected]>
Upgrade Pillow to patched 13.0.0 and target image 1.1.3. Root the tests CODEOWNERS directory rule and cover reviewer ownership and sibling paths. Co-authored-by: Copilot <[email protected]>
Preserve explicit preview overrides, match Studio conversation naming, and disable deployed agent/tool confirmations. Add API and confirmation regressions and fix CP2K static-library build dependencies. Co-authored-by: Copilot <[email protected]>
charwen
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align both Discovery deployment skills with the GA
2026-06-01API while preserving explicit preview configurations, disable agent and tool confirmations in deployed agents, and fix validation conversation naming so Studio can select the session history and output assets. Also repair the CP2K 2024.2 image build by installing binutils, pinning the compatible LibXSMM release, and exposing its pkg-config files.Type of change
agents/<name>/)starter-kits/<name>/)docs/schemas/**).github/**)Related issue / tracking
n/a
Schema impact
breaking-changelabel and link the rollout plan belowValidation checklist
README.md, schemas) is updated to match the change..auto-registry/**(it is generated post-merge)..DS_Store,.env,*.swp,.idea/,.vs/, etc.).Validation performed after merging the latest upstream
main:python -m pytest .github\tests\test_agent_deployer_validation.py .github\tests\test_deployer_api_contracts.py -v -ra— passed: 38 tests and 41 subtests.git diff --check— passed.[System.Management.Automation.Language.Parser]::ParseFile(...)for both deployment runners — passed.ast.parse(...)on eight embedded Python blocks — passed.Earlier live smoke tests of these changes:
The full repository test suite was not run locally; CI remains responsible for broader checks.
Reviewer notes (optional)
/openai/v1/responsesandagent_reference; explicit preview validation uses/openai/responses?api-version=...andagent, including polling and resume.humanInTheLoop: Disabledandconfirmation: Disabledfor all bound tools, overriding explicit source settings. Source agent YAML remains unchanged. Nodepool capacity confirmation and unexpected platform-required approvals are not bypassed.libxsmmextandlibxsmmnoblascomponents supplied by LibXSMM 1.17; its pkg-config files are located directly in the conda environment'slibdirectory.mainwas synced with upstream before this PR branch was prepared. Previously merged agent additions are not part of this PR's changes.