Repository navigation
Add Molecule Visualization agent and RDKit visualization tool - #278
Merged
Merged
Conversation
Include a pinned non-root R tool image, reproducible examples and regression tests. Require real execution evidence during deployment validation, preserve diagnostics, and handle approval continuation without self-approving. Co-authored-by: Copilot <[email protected]>
Ensure clean CI environments can collect the deployment validator regression tests. Co-authored-by: Copilot <[email protected]>
Keep the exact pinned dependency assertion aligned with the deployer test dependency. Verified the full Linux Python 3.12 suite: 907 tests and 11 subtests passed. Co-authored-by: Copilot <[email protected]>
Include 2D and 3D visualization outputs, gallery examples, strict MMFF convergence checks, supported structure helper defaults, and related deployment input/approval fixes. Co-authored-by: Copilot <[email protected]>
Upgrade Pillow to patched 13.0.0 and target image 1.1.3. Root the tests CODEOWNERS directory rule and cover reviewer ownership and sibling paths. Co-authored-by: Copilot <[email protected]>
Suraj Mavilakandy (surajmb)
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the Molecule Visualization agent and version 1.1.3 CPU tool for RDKit-based 2D molecule images, multi-molecule contact sheets, and optional interactive 3D conformers with SDF/PDB/XYZ outputs. Include complete catalog metadata, a non-root container, pinned dependencies, illustrated prompt examples, container regressions, and the related deployment fixes needed to preserve inline input templates and recognize approval requests.
Type of change
agents/<name>/)starter-kits/<name>/)docs/schemas/**).github/**)Related issue / tracking
n/a
Schema impact
breaking-changelabel and link the rollout plan belowValidation checklist
README.md, schemas) is updated to match the change..auto-registry/**(it is generated post-merge)..DS_Store,.env,*.swp,.idea/,.vs/, etc.).Reviewer notes (optional)
Behavior and implementation
{{name}}expressions; validation recognizes "Please approve" and retains the approval flow.Validation evidence
Commands were run after fast-forwarding local
mainfrom the fork:$env:MOLECULE_VISUALIZATION_IMAGE='molecule-visualizations:cif-fix-test'; python -B -m unittest discover -s .\agents\molecule-visualization\tools\molecule-visualization\tests -p 'test_*.py' -v— passed, 10 tests.python -B -m unittest discover -s .github\tests -p test_agent_deployer_validation.py -v— passed, 23 tests, including the actual PowerShell registry-substitution regression.python -B -m pytest .github\tests\test_security_automation.py -q -k 'dependabot_covers_all_requirements_files or ci_python_dependencies_are_pinned_and_workflows_use_the_manifest'— passed, 2 tests.python -B .github\scripts\validate_pr.py --changed-files $list --repo-root . --output $result— passed with all 20 proposed files supplied through a temporary changed-file list and Git'sfileutility on PATH. One non-blocking publisher-contact DNS warning remains because localdnspythonis unavailable.git diff --cached --check— passed.python -B -with a local Markdown-link and Pillow image-verification script — passed, 17 relative links and all six PNG assets.The test-only image overlays the final application source onto the previously validated 1.1.2 runtime; it is not a fresh canonical dependency build. The canonical 1.1.2 Dockerfile previously built successfully with ACR Tasks, while a local canonical build encountered public PyPI TLS handshake failures. The helper-default cleanup was verified in the final-source test image and has not been redeployed.
Discovery tool and agent deployment of 1.1.2 succeeded. Automated cloud validation remains input_required, awaiting platform tool confirmation, and is not claimed as passed. Human-in-the-loop and tool confirmation remain enabled. The full repository test suite was not rerun; focused tests and catalog validation are listed above.
Initial GitHub Actions results
40933181929failed: the tool's pinned Pillow 10.4.0 is flagged by high/critical advisories. This must be resolved before merge; no exception or bypass was applied.40933181850failed on CODEOWNERS expectations intest_pr_review_workflow_security.py. This PR does not change CODEOWNERS or that test file; the latest fork sync includes the recent contributions-reviewer CODEOWNERS update.CI fixes in b819804
/.github/tests/) while preserving both reviewer teams. Add regression coverage for contributions-reviewer ownership of tests, agents, and starter kits and for sibling directory isolation.python -B -m pytest .github\tests\test_pr_review_workflow_security.py .github\tests\test_agent_deployer_validation.py .github\tests\test_security_automation.py -q— passed, 89 tests and 11 subtests.python -B -m unittest discover -s .\agents\molecule-visualization\tools\molecule-visualization\tests -p 'test_*.py' -v— passed, 10 tests, with Pillow 13.0.0 and the final application source. The local test image upgrades the previously tested runtime using an official PyPI wheel whose SHA256 was verified against PyPI metadata; it is not a fresh canonical dependency build.python -B -m pytest .github\tests -q -k 'not test_probe_script_handles_newline_terminated_resolver_output'— passed, 932 tests and 11 subtests, one deselected. The unrestricted Windows run passed those same 932 tests but failed the existing Bash/curl PATH mock test; GitHub's Linux CI runs that test without exclusions.python -B .github\scripts\validate_pr.py --changed-files $list --repo-root . --output $result— passed with no warnings, using all proposed files and restored CI dependencies.git diff --check— passed.No cloud redeployment was performed for 1.1.3. The deployed 1.1.2 tool and its outstanding cloud-validation approval are unchanged.
Fresh GitHub checks for b819804: all 14 passed, including Dependency Review,
the complete Linux unit-test workflow (no exclusions), catalog validation,
schema guards, CodeQL, DevSkim, Secret Scan, and CLA.