Skip to content

Avoid missing early uploads in the manager stress test - #1568

Open
bmehta001 wants to merge 1 commit into
microsoft:mainfrom
bmehta001:bhamehta/fix-manager-upload-wait
Open

bmehta001 wants to merge 1 commit into
microsoft:mainfrom
bmehta001:bhamehta/fix-manager-upload-wait

Conversation

@bmehta001

Copy link
Copy Markdown
Contributor

Why

The multiple-manager stress test snapshots its request counter after starting uploads, so requests that arrive early can be missed and the test can time out even when they were sent.

Changes

  • Capture the baseline before logging and uploading, and still require at least two subsequent requests plus the final logged event.
  • Inspect compressed and uncompressed request bodies without changing the existing default compression setting.
  • Add deterministic checks for early callbacks, pre-existing requests, and a missing final event.

Validation

  • The selected MultipleLogManagersTests.* suite passed five consecutive runs on Visual Studio 2026 Win32 Debug and five on WSL/GCC Debug; this is not a full-suite result.
  • Full repository misspell workflow and git diff --check passed.
  • The existing iOS exclusion for this suite and the unrelated DrMemory test exclusions are unchanged.

This branch starts from current main; the unrelated public-header and runner-fixture failures are being addressed in #1566. Update this branch from main after that PR is reviewed and merged.

File: tests/functests/MultipleLogManagersTests.cpp

Co-authored-by: Copilot <[email protected]>
Copilot-Session: e5009227-6b49-4803-8153-63d8d94037e3
@bmehta001
bmehta001 requested a review from a team as a code owner November 19, 2026 20:43

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant