Skip docker ping on windows - #1874
Merged
Ryan Brandenburg (ryanbrandenburg) merged 1 commit intoSep 18, 2026
Merged
Conversation
Ryan Brandenburg (ryanbrandenburg)
requested a review
from a team
as a code owner
September 18, 2026 18:26
Ryan Brandenburg (ryanbrandenburg)
requested review from
Vie Xian Ong (VXianOng)
and
a lite review from Copilot
September 18, 2026 18:26
Copilot started reviewing on behalf of
Ryan Brandenburg (ryanbrandenburg)
September 18, 2026 18:26
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Skips the Docker ping integration test on Windows and removes the unused Polly dependency.
Changes:
- Excludes
DockerService_CanPingDockerAsyncon Windows. - Removes Polly retry logic and its project reference.
| File | Summary |
|---|---|
test/Microsoft.ComponentDetection.Common.Tests/Microsoft.ComponentDetection.Common.Tests.csproj |
Removes the unused Polly package reference. |
test/Microsoft.ComponentDetection.Common.Tests/DockerServiceTests.cs |
Skips the Docker ping test on Windows and removes retry logic. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Greg Villicana (grvillic)
approved these changes
Sep 18, 2026
Aayush Maini (AMaini503)
approved these changes
Sep 18, 2026
Ryan Brandenburg (ryanbrandenburg)
deleted the
users/rybrande/DockerTest
branch
September 18, 2026 22:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We tried adding Polly retries to make this more stable on windows but no luck. Given that let's just skip it on windows like we do for the rest of these Docker integration tests.