Docker Ping retry delay - #1872
Merged
Ryan Brandenburg (ryanbrandenburg) merged 1 commit intoSep 17, 2026
Merged
Conversation
Ryan Brandenburg (ryanbrandenburg)
requested a review
from a team
as a code owner
September 17, 2026 17:13
Copilot started reviewing on behalf of
Ryan Brandenburg (ryanbrandenburg)
September 17, 2026 17:13
View session
Aayush Maini (AMaini503)
approved these changes
Sep 17, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The change is small, low-risk, and directly targets the reported test flakiness (with only a minor test-runtime tradeoff).
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
This PR aims to reduce intermittent Windows CI flakiness in Docker-related tests by adding retry-with-delay behavior around the Docker daemon ping check.
Changes:
- Add a
Pollypackage reference to the Common test project. - Wrap
DockerService.CanPingDockerAsync()in a PollyWaitAndRetryAsyncpolicy to tolerate slow Docker daemon startup.
| File | Description |
|---|---|
| test/Microsoft.ComponentDetection.Common.Tests/Microsoft.ComponentDetection.Common.Tests.csproj | Adds Polly dependency for retry support in tests. |
| test/Microsoft.ComponentDetection.Common.Tests/DockerServiceTests.cs | Adds retry + delay around Docker ping to reduce Windows CI flakiness. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Ryan Brandenburg (ryanbrandenburg)
deleted the
users/rybrande/DockerTest
branch
September 17, 2026 17:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test fails semi-randomly on windows CI sometimes. My bet is that the docker daemon is slower to startup on windows and hasn't fully spun up, so I've added some Polly retry and delay to hopefully make this more resilient.