Azure Service Data Integration with MLW Template - #405
Open
mahhanifi wants to merge 1 commit into
Open
Conversation
mahhanifi
requested a review
from Erik Schlegel (erikschlegel)
as a code owner
August 10, 2020 17:31
mahhanifi
changed the title
Heba (helayoty)
force-pushed
the
mahanifi/new-template
branch
from
August 26, 2020 00:59
979e4bf to
227556b
Compare
ran the terraform recursive and fixed it changed the cares name into sample Add adf and fix AF to use id
Heba (helayoty)
force-pushed
the
mahanifi/new-template
branch
from
August 26, 2020 02:25
6634f4f to
d18fd18
Compare
Contributor
|
Dexter Williams (@TechnicallyWilliams) Nicholas M. Iodice (@nmiodice) Ready for review! |
mahhanifi
changed the title
Contributor
|
ML is out of my area of expertise but I gave it a good one over. Templates along with tests present no red flags. |
Dexter Williams (TechnicallyWilliams)
approved these changes
Sep 9, 2020
Nicholas M. Iodice (nmiodice)
suggested changes
Sep 25, 2020
| @@ -0,0 +1,139 @@ | |||
| # Azure Application Services | |||
There was a problem hiding this comment.
Is this README correct? Looks the same as some of the app service environments but I don't see reference to any data factory integration in the document
| source = "../../modules/providers/azure/service-plan" | ||
| resource_group_name = azurerm_resource_group.app_rg.name | ||
| service_plan_name = local.func_app_sp_name | ||
| # scaling_rules = var.scaling_rules |
There was a problem hiding this comment.
If this is not needed it can be removed, along with any referenced variables that are not necessary.
| @@ -0,0 +1,114 @@ | |||
| # output "fqdns" { | |||
There was a problem hiding this comment.
Please remove any commented code
| role_scopes = local.rbac_contributor_scopes | ||
| } | ||
|
|
||
| # resource "azurerm_role_assignment" "aks_acr_pull" { |
| sql_collections = local.cosmos_sql_collections | ||
| } | ||
|
|
||
| # //storage for ADF data prep |
| TfOptions: tfOptions, | ||
| ExpectedTfOutputCount: 21, | ||
| TfOutputAssertions: []integration.TerraformOutputValidation{ | ||
| //verifyAppServiceConfig, |
There was a problem hiding this comment.
Please remove this commented section
|
|
||
| func appendKeyVaultTests(t *testing.T, description unit.ResourceDescription) { | ||
| kvBasicExpectations(t, description) | ||
| //kvAccessPolicyExpectations(t, description) |
| "module.app_insights.azurerm_application_insights.appinsights": expectedAppInsights, | ||
| } | ||
|
|
||
| //appendAutoScaleTests(t, resourceDescription) |
| default = "Minute" | ||
| } | ||
|
|
||
| variable "data_factory_dataset_sql_name" { |
There was a problem hiding this comment.
It looks like the interface to this module is changing. Why? Is that needed for this PR?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Any relevant logs, error output, etc?
(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)
Other information