Generate tests in header-parser with CTA - #1282
Draft
Jan Krivanek (JanKrivanek) wants to merge 1 commit into
Draft
Generate tests in header-parser with CTA#1282Jan Krivanek (JanKrivanek) wants to merge 1 commit into
Jan Krivanek (JanKrivanek) wants to merge 1 commit into
Conversation
Nathan Shively-Sanders (sandersn)
left a comment
Nathan Shively-Sanders (sandersn)
left a comment
Member
There was a problem hiding this comment.
A lot fewer changes than the other PR, and it didn't test validPackageJson at all.
| @@ -0,0 +1,9377 @@ | |||
| { | |||
| "name": "definitelytyped-tools", | |||
There was a problem hiding this comment.
shouldn't have created a package-lock
| devDependencies: { "@types/mylib": "workspace:." }, | ||
| }; | ||
|
|
||
| it("returns a valid header for a correct package.json", () => { |
There was a problem hiding this comment.
nice to have 1 additional positive test
| expect(Array.isArray(result)).toBe(false); | ||
| }); | ||
|
|
||
| // nonNpm validation |
There was a problem hiding this comment.
would be nicer as a nested describe like the other PR
| expect(result).toEqual(expect.arrayContaining([expect.stringContaining(`has bad "tsconfigs"`)])); | ||
| }); | ||
|
|
||
| // NOTE: The following tests document current behavior. The validateTsconfigs function |
There was a problem hiding this comment.
good find if true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.