Fix internal admin losing SUPER during customized plan provisioning

[darjoo]

What & why

Internal tenant administrators (Global Admin / Dynamics 365 Admin) lost their SUPER permission set when they were provisioned for the first time and their license plan configuration was customized without explicitly including SUPER. This could lock the first admin out of an environment right after customizing a plan.

The root cause is in codeunit 9018 "Azure AD Plan Impl.", procedure AddNewlyAssignedUserPlans. The internal-admin exemption was only applied on the default (non-customized) plan branch:

if IsPlanConfigurationCustomized then
    ShouldRemoveSuper := not PlanConfigurationContainsSuper   // admin check bypassed
else
    ShouldRemoveSuper := not IsUserAdmin(UserSecurityID);

When any assigned plan was customized and omitted SUPER, the admin check was skipped entirely and SUPER was removed.

The fix adds a local IsUserInternalAdmin helper (Global Admin, D365 Admin, and BC Admin plans only) and guards the customized branch with it:

ShouldRemoveSuper := (not PlanConfigurationContainsSuper) and (not IsUserInternalAdmin(UserSecurityID))

Key decisions:

• Delegated (partner) admins are intentionally not exempted here. Their SUPER is governed separately in AssignPlanToUserWithDelegatedRole, so IsUserInternalAdmin deliberately excludes the delegated/helpdesk plans (unlike the pre-existing IsUserAdmin, which includes delegated admin).
• The default (non-customized) branch is untouched, so default-plan behavior is unchanged.
• SUPER is still only ever revoked during first-login provisioning; existing users are unaffected.

Linked work

Fixes AB#643970

How I validated this

• I read the full diff and it contains only changes I intended.
• I built the affected app(s) locally with no new analyzer warnings.
• I ran the change in Business Central and confirmed it behaves as expected.
• I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome

Added six tests to AzureADPlanModuleTest.codeunit.al (codeunit 139509) exercising RefreshUserPlanAssignments on a customized Premium plan:

• Internal Global Admin + customized plan without SUPER -> retains SUPER.
• Dynamics 365 Admin + customized plan without SUPER -> retains SUPER.
• Ordinary (non-admin) user + customized plan without SUPER -> loses SUPER.
• Any user + customized plan containing SUPER -> retains SUPER.
• Delegated admin + customized plan without SUPER -> loses SUPER (explicitly not treated as internal admin).
• Existing (already provisioned) user -> retains SUPER regardless of customization.

Default-plan behavior remains covered by the existing internal/D365/delegated admin tests.

Note: the affected apps were not built or run in Business Central from this automated environment (no container toolchain available here). Please build the System Application and the _Exclude_PlanConfiguration_ Tests app and run codeunits 132912 and 139509 locally before merging.

Risk & compatibility

• Security-sensitive: this restores a privilege (SUPER) for internal admins that was being incorrectly removed. It does not grant SUPER to any user who should not have it: ordinary users still lose SUPER, and the "contains SUPER" and default-plan paths are unchanged.
• No schema, data, or permission-set changes; no telemetry changes.
• The defect has existed since the initial commit, so it affects all supported releases. Backports to the active releases/24.x through releases/28.x branches are recommended.

[github-actions]

$\textbf{🟡\ Medium\ Severity\ —\ Testing}$

IsUserInternalAdmin() now has three admin-plan branches (Global Admin, D365 Admin, BC Admin), but the new regression tests only exercise the Global Admin and D365 Admin paths (TestInternalAdminKeepsSuperWhenCustomizedPlanOmitsSuper, TestD365AdminKeepsSuperWhenCustomizedPlanOmitsSuper). The BC Admin branch that gates the SUPER-retention behavior is untested. Add an equivalent test using PlanIds.GetBCAdminPlanId() to cover that branch.

_{Agent judgement — not directly backed by a BCQuality knowledge article.}

_{👍 useful · ❤️ especially valuable · 👎 wrong - reply with why · AL review agent v1.15.4}