Repository navigation
Adding end_of_conversation route hook to AgentApplication - #599
Open
Rodrigo Brandão (rodrigobr-msft) wants to merge 2 commits into
Open
Rodrigo Brandão (rodrigobr-msft) wants to merge 2 commits into
Rodrigo Brandão (rodrigobr-msft) wants to merge 2 commits into
Conversation
Copilot started reviewing on behalf of
Rodrigo Brandão (rodrigobr-msft)
September 24, 2026 18:24
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new blob integration test imports A2A modules and a test helper that do not exist, causing pytest collection to fail.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
What changed in this PR
Adds an end_of_conversation route helper and related route and A2A persistence tests.
Changes:
- Adds the end-of-conversation route decorator.
- Tests route matching and handler invocation.
- Adds blob-backed A2A persistence and pagination integration tests.
| File | Description |
|---|---|
agent_application.py |
Adds the route helper. |
test_agent_application_routes.py |
Tests end-of-conversation routing. |
test_blob_protocol.py |
Tests blob-backed A2A task persistence and pagination. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Rodrigo Brandão (rodrigobr-msft)
marked this pull request as ready for review
September 24, 2026 20:47
Rodrigo Brandão (rodrigobr-msft)
requested a review
from a team
as a code owner
September 24, 2026 20:47
Copilot started reviewing on behalf of
Rodrigo Brandão (rodrigobr-msft)
September 24, 2026 20:48
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The implementation is sound, but the PR’s promised blob integration tests are missing.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
Resolved since last review (1)
Copilot started reviewing on behalf of
Rodrigo Brandão (rodrigobr-msft)
September 24, 2026 20:54
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This pull request introduces support for handling "end of conversation" activities in the agent application, along with comprehensive tests to verify the new functionality. The most important changes are grouped below:
New Feature: End-of-Conversation Activity Handling
end_of_conversationmethod to theAgentApplicationclass, allowing developers to register handlers for end-of-conversation activities as decorators or methods. This method supports optional authorization handlers and additional route configuration.Testing Enhancements
TestEndOfConversationRoutetest class to verify the behavior of the newend_of_conversationroute. Tests ensure that: