Skip to content

test: update mql snapshots and fix core setup message - #72

Merged
Kikobeats merged 2 commits into
masterfrom
Kikobeats/update-snapshots
Sep 28, 2026
Merged

Kikobeats merged 2 commits into
masterfrom
Kikobeats/update-snapshots

Conversation

@Kikobeats

@Kikobeats Kikobeats commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

What changed

  • mql snapshots (opts.mjs): logo for kikobeats.com is now https://cdn.microlink.io/logo/logo.png (500x500) instead of /favicon.png (400x400). The site added an <img alt="microlink.io logo">, which the API picks as the larger candidate. Verified with force (cache BYPASS): same result, so a real content change, not stale cache.
  • Pruned orphaned node » / lightweight » snapshot entries in opts.mjs and get-api-url.mjs that no current test produces.
  • core bin/setup.js:204: 7ca6cc7 changed the finish line to gray('Prompt with') + '/microlink', which prints Prompt with/microlink to use it. when color is off (CI, pipes). Restored the space and updated the two test/cli.mjs assertions (788, 834) to the new copy.

How it was tested

  • packages/mql: 32/32 pass.
  • packages/core: 100/100 pass. Reverting the space makes both setup tests fail, so the assertions guard the bug.
  • standard clean on touched files; CI all green.

🤖 Generated with Claude Code

kikobeats.com now embeds a 500x500 microlink.io logo, which outranks the
400x400 favicon in logo detection. Also prunes orphaned `node »` and
`lightweight »` snapshot entries no current test produces.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 2092e201-d9d7-4fbd-a0ad-586d368485a6

📥 Commits

Reviewing files that changed from the base of the PR and between 7ca6cc7 and 898c5fb.

⛔ Files ignored due to path filters (2)
  • packages/mql/test/snapshots/get-api-url.mjs.snap is excluded by !**/*.snap
  • packages/mql/test/snapshots/opts.mjs.snap is excluded by !**/*.snap
📒 Files selected for processing (2)
  • packages/mql/test/snapshots/get-api-url.mjs.md
  • packages/mql/test/snapshots/opts.mjs.md
💤 Files with no reviewable changes (1)
  • packages/mql/test/snapshots/get-api-url.mjs.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The MQL test snapshots remove duplicated URL-generation sections and update the expected logo URL, dimensions, and file size.

Changes

MQL snapshot updates

Layer / File(s) Summary
Snapshot expectations
packages/mql/test/snapshots/get-api-url.mjs.md, packages/mql/test/snapshots/opts.mjs.md
The URL-generation snapshot removes the node » and lightweight » sections. The options snapshot records the logo at https://cdn.microlink.io/logo/logo.png, with dimensions of 500×500 and a size of 5304 bytes.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 898c5

The changes update test snapshots without changing runtime behavior, and the removed sections are not produced by current tests. No concrete merge-blocking risk is established; proceed with normal checks.

Architecture Summary

Architecture risk: 🔵 Low · up to 898c5

The change affects 1 system.

Changed systems: packages/mql

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — packages/mql (library) was modified; 2 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in packages/mql/test/snapshots/get-api-url.mjs.md: Removed the node » and lightweight » snapshot sections, including expectations for URL generation with and without query parameters, API keys, flattened options, null and undefined values, timeouts, and waitUntil.
  • observed — Modified behavior in packages/mql/test/snapshots/opts.mjs.md: The snapshot’s logo metadata changes from the 400×400 kikobeats.com/favicon.png image (3051 bytes, 3.05 kB) to the 500×500 cdn.microlink.io/logo/logo.png image (5304 bytes, 5.3 kB).
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the MQL snapshot updates, which are the main changes. The reference to fixing the core setup message is not supported by the provided changes, but the title remains relate…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Without color, gray() returns the plain string, so the message printed
as "Prompt with/microlink to use it.". Tests now assert the new copy.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@Kikobeats Kikobeats changed the title test(mql): update snapshots test: update mql snapshots and fix core setup message Sep 28, 2026
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 36438045079

Coverage at 80.888% (no base build to compare)

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 1 of 1 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 6024
Covered Lines: 4900
Line Coverage: 81.34%
Relevant Branches: 1024
Covered Branches: 801
Branch Coverage: 78.22%
Branches in Coverage %: Yes
Coverage Strength: 28.27 hits per line

💛 - Coveralls

@Kikobeats
Kikobeats merged commit 70af9cd into master Sep 28, 2026
9 checks passed
@Kikobeats
Kikobeats deleted the Kikobeats/update-snapshots branch September 28, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants