Test outgoing HTTP requests and IssueCommandBase::initialize()

[mglaman]

Closes #382

What changed

Both HTTP clients accept an optional HandlerStack, so tests can wrap a MockHandler with Guzzle's history middleware and assert on the requests the client actually sends. IssueCommandBase::initRepo() throws a RuntimeException instead of calling exit(1), and checks the git rev-parse result before opening the repository.

Why

#381 changed the GitLab auth header and nothing in the suite noticed. The existing Drupal.org client test swapped in a bare Guzzle client, so it could only test response parsing. #385 fixed a crash in initialize() that the one placeholder test could not have caught.

While making the no-repository path testable, it turned out the old catch never fired: realpath('') returns the current directory, so a failed git rev-parse opened a non-repository and failed later with an unrelated GitException. The exit code seen by users is still 1.

New coverage

GitLab client (tests/src/GitLab/ClientTest.php)

• Authorization: Bearer <token> from DRUPALORG_GITLAB_TOKEN, and no auth header when the variable is unset and glab is off PATH
• User-Agent and Accept
• project/drupal encoded as project%2Fdrupal for getProject(), getIssue(), and postIssueNote()
• getIssueNotes() requests page 2 only after a full page of 100
• getIssuesByIid() maps a 404 and malformed JSON to null per iid
• JSON body of a slash command note
• 503 followed by 200 succeeds through the retry middleware

Drupal.org client (tests/src/ClientTest.php)

• Default headers, and Cache-Control / Pragma only with --no-cache
• Cookie persisted across two requests
• Request URLs for nodes and project lookups
• 503 followed by 200 succeeds through the retry middleware

IssueCommandBase (tests/src/Command/Issue/IssueCommandBaseTest.php)

• Bare NID, project#nid, and work item URL all open the repository
• requiresRepository = false never touches git
• NID read from a 3617735-fix_js branch
• "Argument nid not provided" on main, "No repository found" outside a repository

Testing

Each new header and initialize test was checked by reintroducing the original regression (PRIVATE-TOKEN header, and the early return from #385) and confirming the suite fails.

vendor/bin/phpunit        OK (262 tests, 814 assertions)
vendor/bin/phpcs src      clean
vendor/bin/phpstan analyse src   No errors

The 503 retry tests send Retry-After: 0, so the retry middleware does not sleep.

🤖 Generated with Claude Code