Repository navigation
perf: find executable graph nodes with one reverse traversal - #38
Closed
liuzhengyang699 wants to merge 1 commit into
Closed
liuzhengyang699 wants to merge 1 commit into
liuzhengyang699 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before running a graph,
Graph.runsearches forward from every node to see whether it can reach an output. Shared dead branches are revisited along every path, and a sufficiently long valid chain raisesRecursionErrorbefore any agent executes.Walk backward from the output nodes with a visited set instead. Reachability now takes O(V + E) work, avoids recursion, and gives constant-time membership checks during scheduling. The execution queue still follows graph insertion order, and nodes that cannot contribute to an output remain excluded.
Validation:
python -m pytest test/swarm/graph/test_output_reachability.py -q— 4 passed, all markedmock_llm. The tests cover shared ancestors with multiple outputs, a chain longer than the recursion limit, repeated dead diamond branches, and no outputs. The long-chain and bounded-visit cases fail on upstream.git diff --checkpassed. No model calls or end-to-end quality benchmark.