Repository navigation
fix: bound random edge sampling to available candidates - #37
Closed
liuzhengyang699 wants to merge 1 commit into
Closed
liuzhengyang699 wants to merge 1 commit into
liuzhengyang699 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
random_sample_num_edgessamples with replacement until the graph reaches the requested edge count. If the candidates are exhausted or the remaining edges would create cycles, it keeps retrying forever. For example, the two candidatesa -> bandb -> acannot produce a two-edge DAG. This can hang the random-graph baseline inexperiments/crosswords/evaluate.py.Visit candidates once in random order and stop when the target is reached. If this pass cannot reach the target, raise a
ValueErrordescribing the sampled and requested edge counts. Existing edges still count toward the target, and the input graph is left unchanged.Validation:
python -m pytest test/swarm/graph/test_edge_sampling.py -q— 5 passed, no LLM calls. Three regressions fail before the fix; the tests bound sampler calls so the old implementation cannot hang the test run.git diff --checkpassed.