Skip to content

[babel-plugin] Drop floating-point noise when converting ms timings to seconds #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevin9327 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[babel-plugin] Drop floating-point noise when converting ms timings to seconds #1999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/@stylexjs/babel-plugin/__tests__/transform-value-normalization-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,20 @@ describe('@stylexjs/babel-plugin', () => {
`);
});

test('timing values converted to seconds carry no floating-point noise', () => {
const output = transform(`
import stylex from 'stylex';
const styles = stylex.create({
x: { transitionDuration: '33.3ms' },
y: { animationDelay: '11.3ms' },
z: { transition: 'opacity 13.8ms ease-in 10.2ms' }
});
`);
expect(output).toContain('transition-duration:.0333s');
expect(output).toContain('animation-delay:.0113s');
expect(output).toContain('transition:opacity .0138s ease-in .0102s');
});

test('transforms non-unitless property values', () => {
expect(
transform(`
Expand Down
4 changes: 3 additions & 1 deletion packages/@stylexjs/babel-plugin/src/shared/utils/normalizers/timings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ export default function normalizeTimings(
if (!dimension || dimension.unit !== 'ms' || value < 10) {
return;
}
node.value = value / 1000 + 's';
// `33.3 / 1000` is 0.033299999999999996 in floating point; 15 significant
// digits drop that noise without losing any digit a CSS time can carry.
node.value = Number((value / 1000).toPrecision(15)) + 's';
});
return ast;
}