Skip to content

[babel-plugin] Polyfill logical border radius properties - #1997

Open
Xerox563 wants to merge 1 commit into
meta:mainfrom
Xerox563:fix/logical-border-radius-polyfill
Open

Xerox563 wants to merge 1 commit into
meta:mainfrom
Xerox563:fix/logical-border-radius-polyfill

Conversation

@Xerox563

Copy link
Copy Markdown

Fixes #1265.

Logical border radius properties were still emitted as native CSS in the legacy polyfill path, so they did not work in browsers without logical radius support. This emits the native logical property plus a physical fallback behind @supports not (...), keeping direction-aware behavior in modern browsers and falling back to direction selectors otherwise.

The native rule and its fallback are wrapped in @media all so runtime injection can insert them as one rule. Specificity handling now bumps every selector in that block, and width sorting ignores the synthetic media wrapper.

Tests:

  • npx jest __tests__/legacy/transform-logical-properties-test.js __tests__/transform-process-test.js --runInBand
  • BABEL_ENV=test npx jest __tests__/inject-test.js --runInBand
  • npx flow check

@vercel

vercel Bot commented Oct 27, 2026

Copy link
Copy Markdown

@Xerox563 is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@meta-cla

meta-cla Bot commented Oct 27, 2026

Copy link
Copy Markdown

Hi @Xerox563!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@meta-cla

meta-cla Bot commented Oct 27, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 27, 2026
@Xerox563

Copy link
Copy Markdown
Author

The CLA is now signed. The remaining red checks are the Vercel deployment authorization and the GitHub Actions runs waiting for first-time contributor approval. Could a maintainer authorize those and take a look? Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[babel-plugin] Polyfill logical styles for borderRadius

1 participant