Skip to content

[ci] Skip benchmark PR comments on fork PRs and show results in the job summary #1943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
henryqdineen wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[ci] Skip benchmark PR comments on fork PRs and show results in the job summary #1943

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
840afd2
[ci] Skip benchmark PR comments on fork PRs and show results in the j…
henryqdineen Oct 10, 2026
b71a9ef
[ci] Silence yarn in the benchmark compare step
henryqdineen Oct 10, 2026
f296948
[ci] Drop redundant `--` from benchmark runs
henryqdineen Oct 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions .github/workflows/benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
git checkout -f ${{ github.event.pull_request.base.sha }}
git clean -fdx
yarn install --frozen-lockfile --silent
if yarn workspace benchmarks run perf -- -o ${{ env.BASE_JSON }}; then
if yarn workspace benchmarks run perf -o ${{ env.BASE_JSON }}; then
echo "Ran successfully on base branch"
else
echo "{}" > ${{ env.BASE_JSON }} # Empty JSON as default
Expand All @@ -35,16 +35,18 @@ jobs:
git checkout -f ${{ github.event.pull_request.head.sha }}
git clean -fdx
yarn install --frozen-lockfile --silent
yarn workspace benchmarks run perf -- -o ${{ env.PATCH_JSON }}
yarn workspace benchmarks run perf -o ${{ env.PATCH_JSON }}
echo "Ran successfully on patch branch"
- name: 'Collect results'
id: collect
run: |
echo "table<<EOF" >> $GITHUB_OUTPUT
yarn workspace benchmarks run compare -- ${{ env.BASE_JSON }} ${{ env.PATCH_JSON }} >> markdown
yarn -s workspace benchmarks run -s compare ${{ env.BASE_JSON }} ${{ env.PATCH_JSON }} >> markdown
cat markdown >> $GITHUB_OUTPUT
echo "EOF" >> $GITHUB_OUTPUT
cat markdown >> $GITHUB_STEP_SUMMARY
- name: 'Post comment'
if: github.event.pull_request.head.repo.full_name == github.repository
uses: edumserrano/find-create-or-update-comment@v3
with:
issue-number: ${{ github.event.pull_request.number }}
Expand Down Expand Up @@ -78,7 +80,7 @@ jobs:
git checkout -f ${{ github.event.pull_request.base.sha }}
git clean -fdx
yarn install --frozen-lockfile --silent
if yarn workspace benchmarks run size -- -o ${{ env.BASE_JSON }}; then
if yarn workspace benchmarks run size -o ${{ env.BASE_JSON }}; then
echo "Ran successfully on base branch"
else
echo "{}" > ${{ env.BASE_JSON }} # Empty JSON as default
Expand All @@ -89,16 +91,18 @@ jobs:
git checkout -f ${{ github.event.pull_request.head.sha }}
git clean -fdx
yarn install --frozen-lockfile --silent
yarn workspace benchmarks run size -- -o ${{ env.PATCH_JSON }}
yarn workspace benchmarks run size -o ${{ env.PATCH_JSON }}
echo "Ran successfully on patch branch"
- name: 'Collect results'
id: collect
run: |
echo "table<<EOF" >> $GITHUB_OUTPUT
yarn workspace benchmarks run compare -- ${{ env.BASE_JSON }} ${{ env.PATCH_JSON }} >> markdown
yarn -s workspace benchmarks run -s compare ${{ env.BASE_JSON }} ${{ env.PATCH_JSON }} >> markdown
cat markdown >> $GITHUB_OUTPUT
echo "EOF" >> $GITHUB_OUTPUT
cat markdown >> $GITHUB_STEP_SUMMARY
- name: 'Post comment'
if: github.event.pull_request.head.repo.full_name == github.repository
uses: edumserrano/find-create-or-update-comment@v3
with:
issue-number: ${{ github.event.pull_request.number }}
Expand Down
Loading