Repository navigation
Conversation
`PORTABLE MATCHES "1|ON|YES|TRUE|Y"` is an unanchored regex, so any arch name containing one of those substrings is treated as a boolean instead of being passed to -march=. For example, PORTABLE=znver1 or skylake-avx512 builds as PORTABLE=1, and armv8.0-a builds as -march=native. Anchor both patterns so that only the exact boolean values match. Co-Authored-By: Claude Code <[email protected]>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the change to CMake’s PORTABLE handling.
No open issues 🎉
What changed in this PR
Fixes CMake’s PORTABLE handling so CPU architecture names are not mistaken for boolean values.
Changes:
- Anchors both boolean regular expressions to match only complete values.
- Preserves explicit architecture names, such as
znver1andarmv8.0-a, for use with-march=.
| File | Description |
|---|---|
| CMakeLists.txt | Anchors the true and false patterns used to interpret PORTABLE. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PORTABLE MATCHES "1|ON|YES|TRUE|Y"is an unanchored regex, so any arch name containing one of those substrings is treated as a boolean instead of being passed to-march=. For example,PORTABLE=znver1orskylake-avx512builds asPORTABLE=1, andarmv8.0-abuilds as-march=native. Anchor both patterns so that only the exact boolean values match.I've affirmed the CLA.