Repository navigation
[Nexthop][m4061nhp] Add the asic_config_v3 config - #1841
Open
lotus-nexthop wants to merge 1 commit into
Open
lotus-nexthop wants to merge 1 commit into
lotus-nexthop wants to merge 1 commit into
Conversation
lotus-nexthop
force-pushed
the
lotus.m4061nhp-asic-config
branch
from
October 25, 2026 06:40
9708544 to
08f5130
Compare
2 tasks done
lotus-nexthop
force-pushed
the
lotus.m4061nhp-asic-config
branch
from
October 25, 2026 21:23
08f5130 to
2b62bea
Compare
Contributor
|
@lotus-nexthop : Can you remove cc: @marif-nexthop |
Add m4061nhp's asic_config_v3 input and the SDK yaml generated from it. The yaml is the one the default agent.conf for m4061nhp embeds. The platform has a single QSFP28 management port (logical 268, physical 514, 100G x4 RS528), declared with the existing mgmt_port_overrides object form so this change does not depend on meta#1714. validate_asic_configs_contents reports the variant as GENERATED_ONLY: there is no internal reference under synced_asic_configs for a new platform, and that directory is reserved for Meta's sync tooling. Co-Authored-By: Claude Fable 5.1 <[email protected]>
frank-nexthop
force-pushed
the
lotus.m4061nhp-asic-config
branch
from
November 2, 2026 20:52
2b62bea to
df0b18e
Compare
|
Rebased on main past eac25b1 and dropped the synced_asic_configs file. validate_asic_configs_contents reports it as GENERATED_ONLY and all generated outputs regenerate byte for byte. |
Contributor
Author
|
thanks @joseph5wu and @frank-nexthop, I have updated the PR description to match the latest changes. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Add m4061nhp's asic_config_v3 input and the SDK yaml generated from it. The yaml is the same one the default
agent.confin #1840 embeds.Test Plan
python3 fboss/lib/asic_config_v3/gen.py --fboss-root fbossregenerates all variants byte for byte, includingm4061nhp/asic_config/generated/default.yml.validate_asic_configs_schemaspasses.validate_asic_configs_contentspasses, reporting m4061nhp/default as GENERATED_ONLY since it is a new platform with no internal reference.