Skip to content

[Celestica][icecube800bc] Config: Update Fan CPLD driver to fbfancpld, fix COMe 2.0 AMD temp sensors and EEPROM state - #1661

Open
zhongedward wants to merge 2 commits into
meta:mainfrom
zhongedward:add_fbfancpld_driver_for_icecubem
Open

zhongedward wants to merge 2 commits into
meta:mainfrom
zhongedward:add_fbfancpld_driver_for_icecubem

Conversation

@zhongedward

@zhongedward zhongedward commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run
icecubem

Summary

This PR updates platform_manager.json and sensor_service.json for the Icecubem platform to fix Fan CPLD driver configurations, swap COMe temperature sensor definitions, and update EEPROM production states for NETLAKE20.

Main changes include:

  • Fan CPLD Driver Update: Changed MCB_FAN_CPLD kernel device name from icecube_fancpld to fbfancpld and added explicit fanCpldConfig (4 fans, PWM max 64, speed multiplier 300, rear tach enabled).
  • Temperature Sensor Correction: Swapped COMe inlet (0x4a) and outlet (0x4c) tmp75 sensor mappings in both platform_manager.json and sensor_service.json to accurately reflect hardware layout.
  • EEPROM & Sensor Updates: Updated NETLAKE20 production state and sub-state parameters (productionState: 3, productionSubState: 1) and adjusted temperature alarm thresholds accordingly.

Test Plan

  1. Syntax Validation: Validated JSON syntax using jq and JSONLint.
  2. Formatting: Pretty-printed configurations using the jq command for readability.
  3. Build & Config Tests: Compilation and configuration validation tests passed successfully.
  4. Service Verification: Confirmed that platform_manager and sensor_service start and parse the updated Icecubem platform configurations without errors.

Attachments:

icecubem_test_logs_2026_09_20.zip

@meta-cla meta-cla Bot added the CLA Signed label Sep 21, 2026
@zhongedward
zhongedward marked this pull request as ready for review September 21, 2026 07:04
@zhongedward
zhongedward requested a review from a team as a code owner September 21, 2026 07:04
@zhongedward zhongedward changed the title [Celestica] Icecubem: Config: Update Fan CPLD driver to fbfancpld, fix COMe temp sensors and EEPROM state [Celestica][Icecubem] Config: Update Fan CPLD driver to fbfancpld, fix COMe temp sensors and EEPROM state Nov 6, 2026
@zhongedward zhongedward changed the title [Celestica][Icecubem] Config: Update Fan CPLD driver to fbfancpld, fix COMe temp sensors and EEPROM state [Celestica][icecube800bc] Config: Update Fan CPLD driver to fbfancpld, fix COMe 2.0 AMD temp sensors and EEPROM state Nov 6, 2026
@github-actions github-actions Bot added the project:icecube800bc FBOSS project: icecube800bc label Nov 6, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant