fix(aks): run the starter kit on tofu 1.11.5 so its moved blocks work - #254
Merged
Conversation
The starter kit gained moved blocks that cross resource types, from meshstack_tenant_v4 to
meshstack_tenant and from meshstack_building_block_v2 to meshstack_building_block. OpenTofu only
consults the provider's MoveResourceState from 1.10 on; 1.9.0 rejects the statement while validating
the plan, so every run of this definition fails:
Error: Resource type mismatch
This statement declares a move from meshstack_tenant_v4.dev to
meshstack_tenant.dev, which is a resource of a different type.
That killed an ordered AKS starter kit block in the likvid foundation, at all five cross-type
statements at once. The ske starter kit carries the same kind of move and already pins 1.11.5, which
is why it runs.
aks/github-connector and github/repository stay on 1.9.0. Neither declares a moved block.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Contributor
Scorecard Check
📊 meshstack-hub Module Scorecard
📋 Per-Module Category SummaryScore per category per building block.
Core Structure — ✅ all passingBasic module file structure and documentation — applies to 1 modules
Core Structure — Summary
Integration — some checks failingmeshstack_integration.tf conventions — applies to 1 modules
Integration — Summary
Azure Backplane — not applicableAzure UAMI-based automation principal conventions — applies to 0 modules No applicable modules. STACKIT Backplane — not applicableSTACKIT WIF-based automation principal conventions — applies to 0 modules No applicable modules. Testing — some checks failingEnd-to-end test coverage — applies to 1 modules
Testing — Summary
|
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One line:
modules/aks/starterkit/meshstack_integration.tfpinsterraform_version = "1.11.5"instead of1.9.0.Why
The starter kit gained
movedblocks that cross resource types, frommeshstack_tenant_v4tomeshstack_tenantand frommeshstack_building_block_v2tomeshstack_building_block. OpenTofu only consults the provider'sMoveResourceStatefrom 1.10 on. 1.9.0 rejects the statement while validating the plan and never asks the provider, so every run of this definition fails:All five cross-type statements fail at once:
meshstack_tenant_v4.dev,meshstack_tenant_v4.prod,meshstack_building_block_v2.repo,meshstack_building_block_v2.github_actions_dev,meshstack_building_block_v2.github_actions_prod.This was found by ordering an AKS starter kit block against a draft definition version in the likvid foundation. The run failed at
Run Terraform Apply; the runner reported"terraform_version": "1.9.0"with providermeshcloud/meshstack v0.24.4.The ske starter kit declares the same kind of move and already pins
1.11.5, which is why its equivalent test passed on the same runner.Scope
aks/github-connectorandgithub/repositoryalso pin 1.9.0 and stay as they are. Neither declares amovedblock, so neither is affected.🤖 Generated with Claude Code