Skip to content

feat(github-actions-conventions): reserve the maintenance function code-tidying-upkeep - #945

Merged
kyle-sexton merged 2 commits into
mainfrom
feat/vocabulary-code-tidying-upkeep
Nov 3, 2026
Merged

kyle-sexton merged 2 commits into
mainfrom
feat/vocabulary-code-tidying-upkeep

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Refs: melodic-software/claude-code-plugins#12475

Summary

claude-code-plugins is adding the lane maintenance-code-tidying-upkeep. Its resolve-config rejects a lane not named <stage>-<function> from this vocabulary, and the maintenance stage lists no matching function.

Fix

vocabulary.json: reserves the maintenance function code-tidying-upkeep, with its purpose. Nothing else changes.

Verification

Related

🤖 Generated with Claude Code

https://claude.ai/code/session_01VQb9Pzf47aw4gsMAyk98Wn


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T03:49:47.726497Z 5fed893 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kyle-sexton
kyle-sexton enabled auto-merge (squash) November 3, 2026 03:48
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

claude-security-review reviewed 337faa1923594a9613cd6d255c740c3ff80e75e0: 0 finding(s), 0 as inline comments.

No security findings.

Scope: the incremental change since 5fed893 touches only components/github-actions-conventions/vocabulary.json. It renames the reserved function entry code-tidying-upkeep to tidy-code-upkeep and moves it to keep the list alphabetical. The status and purpose values are unchanged.

I checked the change against the trust controls and found none touched. The file is a naming vocabulary. It holds no trusted-actor list, token scope, kill switch, merge hold, workflow, permission, pin or manifest. The entry stays reserved, so no new workflow is admitted and nothing runs. The change has no security-relevant surface.

manifest fields: not applicable, no plugin manifest changed.

critical-findings: 0

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

claude-review reviewed 337faa1923594a9613cd6d255c740c3ff80e75e0: 0 finding(s), 0 as inline comments.

No findings on the incremental change since 5fed893.

What changed: the maintenance function code-tidying-upkeep is renamed to tidy-code-upkeep in components/github-actions-conventions/vocabulary.json. It keeps status: reserved and the same purpose.

What I checked:

  • The new name starts with tidy, which is already in the verbs list. That matches the verb-first check in naming-lint.mjs (the name.split("-")[0] lookup at line 99).
  • The entry moved to sit between sync-standards and verify-governance, so the list is still alphabetical.
  • The old entry is gone, and no other file in the repo refers to code-tidying-upkeep apart from the PR context.
  • I did not run naming-lint.test.mjs. The sandbox blocked the command, so the lint result is unconfirmed.

Not a finding: the PR title and body still say code-tidying-upkeep. The Summary also calls the downstream lane maintenance-code-tidying-upkeep. After the rename the vocabulary no longer lists that name, so the downstream lane in claude-code-plugins (refs #12475/#12614) has to use maintenance-tidy-code-upkeep. I can't verify that from here. The squash commit takes its message from the PR title and body, so updating them to the new name would keep the record accurate.

Closing issue: the PR only references an issue (Refs: melodic-software/claude-code-plugins#12475), so there are no closing-issue criteria to check.

Manifests: the diff touches no plugin manifest.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5fed893049

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kyle-sexton
kyle-sexton merged commit 8214f47 into main Nov 3, 2026
22 checks passed
@kyle-sexton
kyle-sexton deleted the feat/vocabulary-code-tidying-upkeep branch November 3, 2026 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant