Repository navigation
test(code-metrics): add held-out trigger probes for the audit leaves - #13113
Conversation
A fresh agent wrote them blind from the before descriptions, before any rewrite exists. Each file lists the audit router and cross-plugin rivals as competitors, so a live run can contest the should-trigger cases. Refs: #12491 Co-Authored-By: Claude Opus 5.5 <[email protected]>
Refs: #12491 Co-Authored-By: Claude Opus 5.5 <[email protected]>
…etrics-audit-descriptions
Probes change no shipped behavior. Refs: #12491 Co-Authored-By: Claude Opus 5.5 <[email protected]>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed Security review: no security issues foundI read every hunk of all 4 changed files. Each one is a new data file:
Skip gate 2 applies. The change has no security-relevant surface:
The probe request strings are short, realistic developer requests. They contain no embedded directives aimed at a lane or reviewer. The PR description has no embedded text telling the lane to pass the PR, skip a check, drop a finding or post elsewhere. Spend: none. The probe files are inputs for eval runs that have already happened, and this change adds no new runs or schedules. critical-findings: 0 |
|
claude-review reviewed Code review: no findingsI read all 4 changed files in full: three new probe sets under What I checked
Other notes
|
Refs: #12491
Summary
This delivers the probes part of #12491:
plugins/code-metrics/probesnow holds held-out trigger probes for the three remainingaudit-*leaves, written blind by an author who never saw the rewrites. It ships no description change. The preregistered measurement found no control that detected a loss, so all three leaves keep their before text under the issue's own rule (preregistration, result).Fix
plugins/code-metrics/probes/audit-coverage.json,audit-duplication.jsonandaudit-suppressions.json.bump: none, since no shipped behavior changes.Verification
verdict: VALIDunderrun-validity.py, as the result comment records. Every should-trigger case fired 27 of 27 in the before, after and control arms; the control's mean fall was 0.000 with no case drop.scripts/validate-plugins.shpassed on the head before the fragment's bump change, and the fragment checks passed on this head (worker report).git diff --staton this head shows these four files only.audit-coverageattempt lost two arms toOAuth token revoked, cause unverified, and its one preregistered re-run is what the result reports.Related
architecture:map-*, where controls also failed to detect a loss.Remaining
ls -d plugins/code-metrics/skills/audit-* | wc -lis still 6": it reads 3, because PR 12803 folded size, complexity and type-debt into the audit router before the owner's option 3 decision. The owner decides between restoring the leaves and amending the issue.🤖 Generated with Claude Code