Skip to content

docs: replace restated upstream facts with pointers in knowledge and computer-use - #12913

Merged
kyle-sexton merged 7 commits into
mainfrom
replace/pr-12822-upstream-pointers
Nov 3, 2026
Merged

kyle-sexton merged 7 commits into
mainfrom
replace/pr-12822-upstream-pointers

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Refs: #12775

Row r318 (the raw-markdown channel artifacts in the knowledge Anthropic docs profile) is left out of this PR: removing them cuts skill behaviour, which needs before-and-after eval evidence first (docs/review/skills-and-agents.md:6-8). #12775 stays open for that row alone.

Supersedes #12822.

Summary

Carries #12822 (the work-resolve-issue lane's rewrite of the 14 knowledge and computer-use rows of
#12775) to done. The lane could not fetch gnu.org, so rows r316 and r317 were left without their
pointer; this branch merges #12822's head and adds that record.

Fix

Verification

  • The sha2-utilities page was fetched on 2026-11-03 and carries
    id="sha2-utilities_003a-Print-or-check-SHA_002d2-digests".
  • plugins/attribution/skills/audit/scripts/check-stamps.sh --trigger-less on the 8 touched
    markdown files: 36 stamps parsed, 0 findings, 0 declined (the issue's second done-when item).
  • r311 (docs/contracts/plugin-reconfiguration/README.md) is already delivered on main by docs: replace restated upstream facts with pointers in repository docs and bugs #12818:
    caveat 3 keeps the next-session rule, no injection-time description remains, and the record
    points at manifest-reference #reference-a-saved-value with an as-of date and recheck trigger.
  • Verifier notes settled by reading: the r064 anchor #the-idle-timer-does-not-see-claude exists in
    failure-diagnostics.md, which records the 2026-08-10 Windows 11 measurement; the Fetch channel
    section of anthropic-docs-profile.md still records the raw-md artifacts the rule cites; distill's
    "Reading a chapter (PDF)" section holds the Read-tool pointer line 42 refers to.
  • scripts/check-changed-skills.sh --merge-base and scripts/check-changelog-fragments.sh --check
    on the merged head: passed.

Related

🤖 Generated with Claude Code

melodic-automation-lanes Bot and others added 5 commits November 3, 2026 12:43
Lane-Activity: work-resolve-issue/resolve-issue
# Conflicts:
#	docs/contracts/plugin-reconfiguration/README.md
#	plugins/knowledge/README.md
…rows r316, r317)

Fetched the GNU coreutils sha2-utilities page on 2026-11-03; its section
anchor is sha2-utilities_003a-Print-or-check-SHA_002d2-digests, not the
one the issue guessed. Slug step 3 now carries a Pointer, As of and
Recheck trigger record.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Lane-Activity: pr-unblock/resolve-conflicts
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T19:00:28.520532Z 046899f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 046899f6ca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

claude-security-review reviewed dbd5410280597c3da00c2717374f3a5ce3b27e8b: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Security review: PR #12913, incremental since 6597f21 (head dbd5410)

I found no security issues. This was an incremental review. The only file that changed since the last review is .changes/knowledge/work-resolve-issue-issue-12775-41622714989-1-bbd8e55f.md, and I read its whole hunk. It doesn't match any trusted-path glob.

What changed: the changelog fragment drops a claim about what was removed from the docpage-digest Anthropic docs profile. The bullet now says only that docpage-digest no longer names which systems lack sha256sum. This is release-note prose. It is not a standing instruction, a skill body, a rule or a hook. It changes no code, workflow, manifest (plugin.json / marketplace.json), token scope or trust control. The removed sentence that source.* stays the unaltered fetch only described the change. The rule itself lives in the skill and profile files, which haven't changed since the last review and were checked then.

Prior findings: none from this lane (round 0 of a cap of 3), so the cap does not apply. No settled threads affect this change.

No manifest items were touched, and the change has no cost-relevant surface.

critical-findings: 0

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

claude-review reviewed dbd5410280597c3da00c2717374f3a5ce3b27e8b: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Code review (incremental since 6597f21): no findings. I read every hunk of the one file in scope, .changes/knowledge/work-resolve-issue-issue-12775-41622714989-1-bbd8e55f.md. It does not fall under a trusted path.

What changed: the knowledge fragment no longer says that the Anthropic docs profile drops the raw-markdown fence, tab and URL-escaping artifacts. That now matches the pull request:

The remaining bullet, "docpage-digest no longer names which systems lack sha256sum", matches the docpage-digest change: the stock-macOS clause is gone, the fallback command stays, and a GNU coreutils pointer is added. bump: patch is still the right level for a docs-only change.

Other checks:

  • No plugin manifests changed.
  • No settled thread or prior finding applies to this change. The prior-findings file lists only this lane's earlier no-findings summary.
  • I found no instructions embedded in the PR context or settled-thread text.
  • This change is docs-only, so it adds no run cost.

…s profile

The removed lines are this skill's own observations of what the raw-md
channel delivers (theme={null} fences, hard-tab expansion, escaped URLs),
which the archive-reading rule reproduces byte-exact. Dropping them is a cut
to the skill's behaviour, not a pointer swap, so keep them unchanged.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01MWmASPDSoP4Ps23JPiGyZV
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

The pr-verify verifier failed head 6597f21ba86f39066b4fcf8d00ce1f5a96e8255e. What it wrote, as data:

What it wrote (31 lines)
Summary: Issue #12775: the diff fixes 13 of its 14 rows but leaves out r318.
  `plugins/knowledge/skills/docpage-digest/context/anthropic-docs-profile.md` is not in the diff, so
  its list of raw-markdown channel artifacts is still there. The issue's first done-when item says
  every row must be fixed, and the issue says to remove those sentences when no docs page documents
  them. The knowledge changelog fragment also claims this removal was made, which is false. The
  other rows check out: r309, r313, r314, r316, r317 and r321 in knowledge, and r060 to r065 in
  computer-use. The PR body says r311 already landed on main in #12818. The CI jobs that ran on the
  judged head passed.
- plugins/knowledge/skills/docpage-digest/context/anthropic-docs-profile.md: row r318 is not
  delivered. The file is not in the diff; the review comment says it was restored to main byte for
  byte so that the eval rule in docs/review/skills-and-agents.md would not apply. Remove the list of
  channel artifacts (the theme={null} fence attributes, tab expansion and escaped URLs). Keep, in
  this repository's own words, that source.* stays the unaltered fetch and that digests reproduce
  artifacts and never repair them. Whatever eval docs/review/skills-and-agents.md requires for such
  a cut, satisfy it rather than skipping the row.
- plugins/knowledge/skills/docpage-digest/SKILL.md: the PR body says the Fetch channel section of
  anthropic-docs-profile.md still records the raw-md artifacts that this skill's rule cites. If that
  rule restates the artifacts, change it to match when you cut the profile.
- .changes/knowledge/work-resolve-issue-issue-12775-41622714989-1-bbd8e55f.md:13: the fragment says
  the Anthropic docs profile no longer lists the fence, tab and URL-escaping artifacts, but this
  diff does not change that file. Make the fragment match what the diff delivers.
- docs/contracts/plugin-reconfiguration/README.md: row r311 is not in this diff. The PR body says
  #12818 already delivered it on main; I could not check that from the provided files.
- plugins/knowledge/skills/docpage-digest/SKILL.md:21: the GNU coreutils pointer uses the anchor
  `#sha2-utilities_003a-Print-or-check-SHA_002d2-digests`, not the one the issue suggested. The PR
  body says this is the page's real anchor; I could not check it here.
- upstream-jobs.json: test-bash, test-node, check-skills, check-plugins and lint-repo all concluded
  success on the judged head
  (https://github.com/melodic-software/claude-code-plugins/actions/runs/41709362129/job/126180515875
  is check-skills). test-python was skipped, which is expected because the diff has no Python
  changes.

This pull request leaves the merge queue, and ci-status holds it out while it carries pr-verify-failed. A pr-verify pass at a new commit removes the label.

@github-actions github-actions Bot added the pr-verify-failed pr-verify failed this head; a pass at a new commit removes it. label Nov 3, 2026
Row r318 (the raw-markdown channel artifacts in the Anthropic docs profile)
is left out of this change: removing it cuts skill behaviour, which needs
before-and-after eval evidence first. The fragment no longer claims it.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01MWmASPDSoP4Ps23JPiGyZV
@github-actions github-actions Bot removed the pr-verify-failed pr-verify failed this head; a pass at a new commit removes it. label Nov 3, 2026
@kyle-sexton
kyle-sexton added this pull request to the merge queue Nov 3, 2026
Merged via the queue into main with commit e5389b6 Nov 3, 2026
52 of 53 checks passed
@kyle-sexton
kyle-sexton deleted the replace/pr-12822-upstream-pointers branch November 3, 2026 21:32
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Post-merge mutation testing

Killed 0, survived 6, timeout 0, no coverage 0, invalid 0, not run 1.
Covered-code score 0%; mutation score 0%.

File Killed Survived Timeout No coverage Invalid Not run
plugins/architecture/lib/config-cascade.mjs 0 2 0 0 0 0
plugins/architecture/lib/state-key.sh 0 1 0 0 0 0
plugins/architecture/lib/view-registry.mjs 0 1 0 0 0 0
plugins/architecture/lib/view-settings.mjs 0 2 0 0 0 0
plugins/architecture/lib/yaml-subset.mjs 0 0 0 0 0 1

Surviving mutants

Location Operator Disposition Cause
plugins/architecture/lib/config-cascade.mjs:148 ROR productive input-gap
plugins/architecture/lib/config-cascade.mjs:219 LCR productive input-gap
plugins/architecture/lib/view-registry.mjs:72 UOI productive input-gap
plugins/architecture/lib/view-settings.mjs:59 ROR productive input-gap
plugins/architecture/lib/view-settings.mjs:108 UOI productive input-gap
plugins/architecture/lib/state-key.sh:116 other productive no-assertion

The run's summary has the full report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant