Skip to content

feat(docs-hygiene): rename-references auto-applies the Certain bucket and reports it - #12604

Open
melodic-automation-lanes[bot] wants to merge 2 commits into
mainfrom
work-resolve-issue/issue-12593-41562938141-1
Open

melodic-automation-lanes[bot] wants to merge 2 commits into
mainfrom
work-resolve-issue/issue-12593-41562938141-1

Conversation

@melodic-automation-lanes

Copy link
Copy Markdown
Contributor

Closes #12593

Summary

Opened by the work-resolve-issue lane. The run's own summary:

The rename-references Certain bucket no longer asks a per-bucket AskUserQuestion: once the proceed gate passes it auto-applies by its stated default, and the bucket-count report gives the count, 1-2 example matches, and how to review the bucket one by one instead (answer the proceed prompt with "review Certain one-by-one"; the matches then use the Ambiguous per-match format with a "skip remaining Certain" option, before the Chain-context flow). triage.md and apply.md now say the same thing (this also covers sibling slice #12592's apply.md ask, as the issue asked), and SKILL.md's step 4 summary was updated to match. The Chain-context and Ambiguous flows and the proceed/abort gate line are unchanged; the escape hatch is written as an answer to the existing gate, not as a new gate option, to keep that gate unchanged.

Not verified

  • Review finding not applied: listing "review Certain one-by-one" as an explicit third option of the proceed gate. That would change the proceed/abort gate the issue requires unchanged; the route is reachable as a free-text answer to that gate.
  • No eval added for the new Certain-bucket behavior (no prompt, report contents, review route); the issue did not ask for one.
  • ai-slop deterministic detector (detect.sh) not run: the lane allows only its named wrappers. The changed lines were read by hand against the catalog (no em dashes, AI vocabulary or chat residue found).
  • Tidy ran passes 4 and 5 only (the change is all markdown; passes 1-3 apply to code). write-for-agents tightened the triage.md line 31 wording; write-for-humans was not invoked separately for the changelog fragment, which got the ai-slop read.
  • CI-only checks listed by check-affected (markdownlint, evals-quality, line-citations, purged-em-dashes and others) are left to the PR's CI.
  • Untracked runner files in the checkout (.bash_profile, .bashrc, .gitconfig, .idea, .mcp.json, .profile, .ripgreprc, .vscode, .zprofile, .zshrc) are not part of this change.

Fix

  • plugins/docs-hygiene/skills/rename-references/context/triage.md: Bucket 1 User flow auto-applies after the proceed gate and reports instead of asking; the bucket-count report template adds the Certain example and review-one-by-one lines, printed only when the Certain count is above 0.
  • plugins/docs-hygiene/skills/rename-references/context/apply.md: Phase 4 Certain bucket bullets match triage.md (no per-bucket AskUserQuestion, report count, examples and the review route); "skip remaining Certain" added to the answers that produce skip records.
  • plugins/docs-hygiene/skills/rename-references/SKILL.md: workflow step 4 lead-in and Certain bullet describe the report, the proceed gate and the auto-apply.
  • .changes/docs-hygiene/work-resolve-issue-issue-12593-41562938141-1-fee581f4.md: new minor changelog fragment for docs-hygiene.

Verification

The runner ran each check from the base copy against 5ff1edc:

  • scripts/check-changelog-fragments.sh --check: passed
  • scripts/check-changed-skills.sh --merge-base: passed

The run reports:

  • check-changelog-fragments: all 14 fragments valid (run before and after tidy and review fixes).
  • check-changed-skills: rename-references PASS, 0 errors, 3 pre-existing warnings (description length, body length, numbered procedure at lines 97-100, none in changed lines).
  • check-affected: 11 passed, 7 skipped over 4 changed files.
  • Grep for line-number citations of rename-references SKILL.md/triage.md/apply.md: none, so the shifted lines break no citation.
  • Unchanged-text check: triage.md Bucket 2 User flow, Bucket 3 User flow and the 'Use AskUserQuestion to gate the proceed/abort decision.' line are byte-identical to before (confirmed by the review subagent).
  • Fresh-context review subagent over the whole diff: no contradictions; 6 minor findings, 5 fixed (SKILL.md step-4 lead-in, scoped skip option and ordering of the Certain review, proceed-gate wording, preview-mode clause, print Certain lines only when count > 0).
  • The lane run: https://github.com/melodic-software/claude-code-plugins/actions/runs/41562938141

Left out: the items under Not verified.

Related

#12593

Lane-Activity: work-resolve-issue/resolve-issue
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 0eaa3198ca47f2d0455900650aaca009297b40de: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Security review: PR #12604 (head 0eaa319), incremental since 5ff1edc

Result: no security issues found.

What I reviewed: This was an incremental review, and the only file in scope was plugins/docs-hygiene/skills/rename-references/evals/evals.json. I read its single hunk in full. The push adds one eval case (id 49, certain-bucket-auto-applies-without-a-per-bucket-question). The case checks that the Certain bucket applies after the proceed gate and that the bucket-count report shows the "review Certain one-by-one" route.

What it touches:

  • The file is eval test data. It matches no TRUSTED PATHS: glob.
  • The push changes no plugin manifest, workflow, action, script, token request, trusted-actor list, kill switch or merge hold.
  • It removes or loosens no standing instruction, so the instruction-surface lens has nothing new to check.
  • The eval prompt only names local files (README.md, docs/guide.md). It carries no secrets and nothing that runs.

Earlier review: The skill-body changes this eval covers were reviewed at 5ff1edc and found clean. That review checked the removed per-bucket question against the instruction exception register: the proceed/abort AskUserQuestion gate still runs before any edit.

PR context: It contains no embedded instructions aimed at this lane.

Spend: none beyond normal CI. One more eval case means slightly more prepaid eval runtime when evals run.

critical-findings: 0

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

claude-review: 1 inline finding(s) on 5ff1edc9b8168793883db406905a1c397b38639c; the summary is in this lane's pull request comment.

claude-lane: claude-review

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

claude-review reviewed 0eaa3198ca47f2d0455900650aaca009297b40de: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Code review (incremental): PR #12604, 5ff1edc9..0eaa3198

Scope: One file changed since the last review, plugins/docs-hygiene/skills/rename-references/evals/evals.json. I read its one hunk, which adds eval 49, and checked the case against the head context/triage.md. That file defines the Form 1 and Form 3 Certain forms (lines 21-22) and the bucket-count report template and its count > 0 condition (lines 158-170).

Prior finding (missing eval for the Certain flow): Eval 49 fixes this. It is an apply-mode case whose only hits are Certain: a Form 1 slash token, and a Form 3 skills/<old>/ path, which is Certain-eligible in both identifier and container-rename mode. Its expectations cover the four points the finding raised:

  • no question is asked for the Certain bucket itself, so the proceed gate is the only question
  • the report shows the count, 1-2 examples and the "review Certain one-by-one" route
  • both edits are applied after the proceed answer
  • the one-by-one route uses the per-match format with a skip remaining Certain option

The wording matches the triage.md template and apply.md Phase 4. The thread is resolved and its lines have not changed since, so it stays settled.

New findings: None.

Not verified: The changelog-fragment, changed-skills and check-affected checks are the author's claims. I did not run them because this lane has no shell. I did not run eval 49 either.

Embedded text: None found in the PR context, settled threads or prior findings.

@melodic-automation-lanes

Copy link
Copy Markdown
Contributor Author

Unattended merge: native auto-merge leaves this pull request unarmed at head 5ff1edc9b8168793883db406905a1c397b38639c. The lanes clear this reason on their own; the next scheduled run judges it again.

pr-merge's gate refuses its verifier verdict (verify:unreadable)

@melodic-automation-lanes

Copy link
Copy Markdown
Contributor Author

The unattended merge path armed native auto-merge at head 5ff1edc9b8168793883db406905a1c397b38639c.

Lane-Activity: pr-unblock/address-feedback
Lane-Thread: PRRT_kwDOTCGFQM6y9DJ3
@melodic-automation-lanes

Copy link
Copy Markdown
Contributor Author

pr-unblock / address-feedback finished round 1 of max 4 on 0eaa319.

@melodic-automation-lanes
melodic-automation-lanes Bot added this pull request to the merge queue Nov 3, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 3, 2026
@kyle-sexton
kyle-sexton added this pull request to the merge queue Nov 3, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 3, 2026
@kyle-sexton
kyle-sexton added this pull request to the merge queue Nov 3, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 3, 2026
@melodic-automation-lanes

Copy link
Copy Markdown
Contributor Author

@kyle-sexton kyle-sexton added the do-not-merge Hard merge gate: do not merge while applied. label Nov 3, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge Hard merge gate: do not merge while applied.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(docs-hygiene): rename-references triage auto-applies the certain bucket and reports it

1 participant