Skip to content

code-tidying: make the remove-comments body rules measurable #12703

Description

@kyle-sexton

Refs: #12474

Problem

The eval suites can't detect a loss in the remove-comments and audit body rules, so #12549 shipped those rules with the gap disclosed, on the owner's decision on #12474.

Measured

Deleting each skill's procedure steps barely moved its outcome suite, against a 0.15 detection line:

  • dissolve-comments body control: mean fall 0.010, no case drop.
  • audit-comment-residue body control: mean fall 0.083, no case drop.

15 of 21 same-contract cases scored the same across before, after and the control. tree-sitter does not reach the eval sandbox, so every arm only proposes deletions, and an applied deletion is never measured.

Done when

Activity

  1. added
    host-runNeeds an unattended run on a host; the host runner takes it, not a person or the issue lane.
    on Nov 3, 2026
  2. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 3, 2026
  3. github-actions commented on Nov 3, 2026

    @github-actions
    Contributor

    Proposed work class: work-class: scoped
    Basis: automated intake triage; the lanes App applied this class.

    Size: Medium
    Complexity: Medium
    Uncertainty: Knowable
    Flags: none
    Blocked by: none

    Understood: the eval suites for dissolve-comments and audit-comment-residue can't detect a loss in the body rules shipped in #12549. Deleting the procedure steps moved the outcome suites by less than the 0.15 line. The work is to get tree-sitter or an equivalent running in the eval sandbox, or to exercise applied deletions another way. It also needs a negative control on each skill's body that does detect a loss, and a before/after measurement with those controls. Nothing is missing that blocks triage. I found no duplicate among the open issues I checked. This is related to #12474.

    Automated triage, applied by the lanes App.

  4. added
    priority: mediumReal value, no hard deadline; normal backlog flow.
    and removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 3, 2026
  5. github-actions commented on Nov 3, 2026

    @github-actions
    Contributor

    The triage sweep dispatched intake triage for this issue (attempt 1 of 2).

  6. added
    status: readyTriaged, unblocked, and fully specified; eligible to pick up.
    work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.
    on Nov 3, 2026
  7. added
    status: confirmedA maintainer confirmed the item is real and in scope; ready to be worked.
    and removed
    status: readyTriaged, unblocked, and fully specified; eligible to pick up.
    on Nov 3, 2026
  8. melodic-automation-lanes commented on Nov 3, 2026

    @melodic-automation-lanes
    Contributor

    Not admitted to the issue lane: it carries host-run. Admission takes the issue once each of those is met, when intake triages it again (.github/actions/resolve-config/admission-rules.json).

  9. melodic-automation-lanes commented on Nov 3, 2026

    @melodic-automation-lanes
    Contributor

    The latest triage verdict holds nothing: admission moved the issue to status: confirmed; its comment says why.

  10. kyle-sexton commented on Nov 3, 2026

    @kyle-sexton
    MemberAuthor

    Claim. Lane 5 host run is building this now (R29, oldest unclaimed buildable host-run item after #12242, which is date-gated to 2026-11-04T19:13Z).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    host-runNeeds an unattended run on a host; the host runner takes it, not a person or the issue lane.priority: mediumReal value, no hard deadline; normal backlog flow.status: confirmedA maintainer confirmed the item is real and in scope; ready to be worked.work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.

    Type

    Fields

    Work status

    confirmed

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions