Repository navigation
Update unit tests to use pyepics.exceptions instead of Python exceptions - #12
Merged
Merged
Conversation
Collaborator
Author
|
@melekderman I'm unable to request you for review through the github interface (repo permissions), so I'll just ping you here. Thank you! |
Owner
|
@hansenkyle, thanks for catching and fixing this! I just realized we actually do not have a workflow set up for unit tests for PR. :) I will go ahead and fix it so we can run the tests and get this merged. |
melekderman
self-requested a review
November 4, 2026 23:19
melekderman
had a problem deploying
to
testpypi
November 4, 2026 23:43 — with 
GitHub Actions
Failure
GitHub Actions
Failure
melekderman
approved these changes
Nov 4, 2026
melekderman
left a comment
melekderman
left a comment
Owner
There was a problem hiding this comment.
Thanks to this PR #12, we also caught other issues that were missed because the tests were turned off for PRs and pushes to dev. Thanks, @hansenkyle!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several unit tests were expecting python exception types, but they got the custom PyEPICS exception types. I've updated these tests to expect the new types. Note that there is still one failing unit test (
mcdc_gpf.test_synthetic_model_output_schema) for an unrelated reason so I left this one alone.