Skip to content

Fix onlinestats to skip NaNs in grouped online stats - #57

Merged
meggart merged 2 commits into
mainfrom
fg/online
Feb 20, 2026
Merged

Fix onlinestats to skip NaNs in grouped online stats#57
meggart merged 2 commits into
mainfrom
fg/online

Conversation

@meggart

@meggart meggart commented Feb 20, 2026

Copy link
Copy Markdown
Owner

No description provided.

@meggart
meggart merged commit a02a3bd into main Feb 20, 2026
2 of 4 checks passed
@codecov

codecov Bot commented Feb 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.82%. Comparing base (53d412a) to head (e33ad1a).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/graphs.jl 0.00% 7 Missing ⚠️
src/util/onlinestats_helpers.jl 0.00% 6 Missing ⚠️
src/util/aggregate.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
- Coverage   45.93%   45.82%   -0.11%     
==========================================
  Files          23       23              
  Lines        2129     2134       +5     
==========================================
  Hits          978      978              
- Misses       1151     1156       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 22227847838

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 14 (0.0%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 45.829%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/util/aggregate.jl 0 1 0.0%
src/util/onlinestats_helpers.jl 0 6 0.0%
src/graphs.jl 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
src/graphs.jl 3 51.33%
Totals Coverage Status
Change from base Build 22227643098: 0.0%
Covered Lines: 978
Relevant Lines: 2134

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants