Repository navigation
fix(promises): name the pr-recap exception in the review acknowledgment claim - #321
Merged
Merged
Conversation
…nt claim The ledger claim for babysit-body-only-finding-acknowledged-in-pr-comment said any author or maintainer comment with the review's URL acknowledges a bot review body. Since #305, acknowledgment() in watch-pr/review-bodies.ts skips a comment that opens with the pr-recap start marker. The claim now says so, and its script check gains a pr-recap case that fails when that guard is removed. Closes #315
Owner
Author
|
Verdict: PASS+NOTES Root verdict from a full swarm at the code-ready head. Three lanes ran: gates and live (sonnet@high), claim vs code (sonnet@xhigh), and graders and ledger (sonnet@xhigh). The two review lanes stepped down from the opus work model.
Notes, filed as #325:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The ledger claim for
babysit-body-only-finding-acknowledged-in-pr-commentsaid any author or maintainer comment with the review's URL acknowledges a bot review body. Since #305 the watcher ignores a comment that opens with the pr-recap start marker, so a grader reading the claim expected the wrong thing.What changed
Scope
Ledger text and one test case. No watcher code changes. Other text that states the rule already matched the code: babysit step 8 names the exception, and the guide and watcher hint only say what to post.
Blast Radius
Promise grading for one ledger entry. Low risk.
Verification
review-bodies.ts, the new case fails (the watcher returns READY). With the guard in place, it passes.ledger.py audit: 0 problems.ledger.py format --check: exit 0.tools/gate-check.sh lintpassed. In the test tier, promise unit tests passed. Onehost.test.tslookup case timed out at 5s under load and passes alone; this PR touches no TypeScript.review-bodies.test.tscase "rejects a pr-recap comment that links the review" covers the code path.Closes #315
✅ Low: This change rewords one ledger claim and adds one test subtest. The new claim matches
acknowledgment(), which checkstrimStart().startsWith(RECAP_START)together with a trusted author andlinksReview. The new subtest is a trusted author comment that starts with a newline and then the recap marker, and the.after the URL still satisfieslinksReview. So only the recap guard keeps that comment from counting, and the subtest fails when the guard is removed.Updates from git push no-mistakes