Repository navigation
fix: correct promise evaluation edge cases - #202
Conversation
189df61 to
7cbbaa9
Compare
|
Verdict: FAIL Round 1 swarm at this head: gates + independent differential regrade + live (sonnet@high), oracle-logic review and tests/fixtures/docs review (opus@xhigh each; work model sonnet@high). Gates: lint 5/5, test_oracles 472 OK; only known host noise. Differential: 2528 saved gradings regraded with an independent tool; the same 9 rows moved as the owner reported, all intended; no correct reply newly FAILs; across 161 mutated negations the only new PASS is the intended "Safety fact" wording. Live: the run-tmp graft now PASSes, lookalikes stay project edits, the dropped- Fix-forward (in scope):
Ordering: README:70 describes arena's per-run Follow-ups (not this PR; filed): sealed-brief INCONCLUSIVE ignores whether arena was read (invented input reaches it; recorded sealed runs read arena); "safety fact" has no negation check; the new ask-tool names make a non-blocking |
7cbbaa9 to
e6a3c1e
Compare
|
Verdict: FAIL Round 2 swarm at this head: gates + checkout-location + live (sonnet@high), docs-claim review and test-patch review (opus@xhigh each; work model sonnet@high). This is the second FAIL; a third stops the PR. Oracle logic is byte-identical to round 1. Gates pass; RunRootTmp passes from /private/tmp and $TMPDIR checkouts and still fails with the run-tmp rule disabled; the prefix patch never leaks across 747 tests in forward, reversed and shuffled orders. Live checks match round 1. Fix-forward (docs only;
|
…eruns Accept Codex request_user_input_async and Grok ask_user_question as ask tools. Return INCONCLUSIVE, not FAIL, when sealed briefs hide the architect runners. Accept an indented example prompt and fail a public link that drops skills/. Read 'safety fact' as the one-fact framing and ignore scratch proof scripts when counting files beyond the diff. Move the remaining heuristic gaps to the promises README. Refs #175
…ying edits Every adapter sets TMPDIR to <run root>/tmp. An arena graft written there was graded a project edit and failed architect-checkpoint-opt-in. Refs #175
…nd state which gap moved verdicts
…ount under Known oracle gaps The pasted-command edge moved 8 recorded verdicts, not 3, and an env-var prefix defeats the 40-character match. The failed-command-chain edge moved 4 Codex verdicts and was not listed.
e6a3c1e to
aefc8c5
Compare
|
Verdict: PASS+NOTES Round 3 swarm at this head: gates + scope + merges (sonnet@high), citation recount and mechanism review (opus@xhigh each; work model sonnet@high). Only evals/promises/README.md changed this round; oracles.py and grade_boundary.py are byte-identical to round 2. Gates pass (only known host noise); test_oracles 472 OK; CI 7/7. An independent scan confirms the pasted-command count (8 of 9 saved runs) and the failed-read count (4 of 2,552 regraded verdicts), every run id and line citation, and that no other listed edge moved a recorded verdict. The pasted-command bullet's mechanism matches the oracle on synthetic traces. Merges clean with main, #201, #203, #205. Note (follow-up #207 item 6): README:103 calls the second edge a "command chain"; the mechanism is any failed shell call, and relay-__ceheht failed a single multi-file Merge order: this PR may land before #201 (its oracle change is safe alone; README's arena path sentence becomes exact when #201 lands). |
What Changed
skills/.Validation
Risk Assessment
✅ Low: This round changes only the README. Its claims match the source: blast_proves takes the first 40 characters of the full command, environment-variable prefix included. load_attempts records a failed chain as read-unknown with ok=False, and the reads filter drops it. The cited results files and anchors exist, and the 3+3+2 = 8 and 2+2 = 4 counts agree with the listed run ids.
Testing
Focused tests and 35 native CLI grading cases passed after correcting a test-directory naming collision. Retained CLI verdicts and documentation inspection evidence; removed disposable assets. The documentation has no live runtime scenario.
Evidence: Live CLI grading inputs and verdicts
Evidence: Reproducible CLI driver
Evidence: Documentation contract inspection
Pipeline
Updates from git push no-mistakes
✅ **Intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
PYTHONDONTWRITEBYTECODE=1 TMPDIR="$PWD/.phase-test-tmp" PYTHONPATH=evals/promises python3 -m unittest -v test_oracles.SyncDf58112Edges test_oracles.RunRootTmp test_grade_boundary.NativeParentBoundary.test_help_links_retain_skill_directory_proof_in_native_snapshotsPYTHONDONTWRITEBYTECODE=1 TMPDIR="$PWD/.phase-test-tmp" python3 .phase-test-tmp/drive.pysubmitted 35 fresh synthetic inputs through the reallive.py grade --out <isolated-out> <authorization-id>CLI.Inspected the latest commit's README diff and cited repository result documents.Removed disposable grading environments and verifiedgit status --shortwas empty.✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.