Skip to content

promises: the acknowledgment ledger claim omits the pr-recap exception from #305 #315

Closed

Description

@mdsmithaustin

The ledger claim for babysit-body-only-finding-acknowledged-in-pr-comment says a bot review stays open "until a PR comment ... contains that review's URL". #305 changed this: acknowledgment() in skills/poteto-mode/scripts/watch-pr/review-bodies.ts now skips any comment that starts with the pr-recap start marker. The claim doesn't mention that exception, so it no longer matches the code.

The fix is one clause in the claim: "a PR comment other than a pr-recap comment". A grader that reads the claim then expects the same thing the code does.

Found by the PR 312 audit lane (opus@xhigh). The defect is already on main at ee59a17a, so it doesn't gate PR 312.

Activity

  1. added a commit that references this issue on Oct 26, 2026
    708b54b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions