build: switch library/CLI bundling from rollup to esbuild - #81
Merged
Merged
Conversation
Rollup and esbuild were both in use (esbuild only for the GitHub Action bundle), so this drops the redundant tooling. Type declarations are now generated separately via tsc --emitDeclarationOnly since esbuild doesn't emit .d.ts files. Also drops the unused UMD output, which nothing in the repo referenced. cli.ts switches from import.meta.url to __dirname for locating package.json, since esbuild's CJS output leaves import.meta.url empty (Rollup shimmed this automatically; esbuild does not). Co-Authored-By: Claude Sonnet 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01PgrCBtiV8FbFLrHv3zrCgN
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/index.tsandsrc/cli.ts(esbuild was already a devDependency, used for the GitHub Action bundle).tsc --emitDeclarationOnly, since esbuild doesn't emit.d.tsfiles.dist/index.umd.js.src/cli.ts: switch fromimport.meta.urlto__dirnamefor locatingpackage.json. Rollup shimmedimport.meta.urlfor CJS output automatically; esbuild leaves it empty in CJS, which silently broke--version.rollup,@rollup/plugin-terser,@rollup/plugin-typescriptdevDependencies androllup.config.mjs.Test plan
npm run build— clean, producesdist/{index,cli}.{mjs,cjs}(+min variants) anddist/typings/**node dist/cli.cjs --version/--help— worksnpm test— 377/377 passing, 100% coveragenpm run lint— cleannpm run lint:dependencies(knip) — clean🤖 Generated with Claude Code
https://claude.ai/code/session_01PgrCBtiV8FbFLrHv3zrCgN