Conversation
…okup Look up records by recordId (mapped from the claim set identifier) for the new Claim sets tutorial, and by licenseNumber for the Claims source tutorial. The lookup previously read an email query parameter that no record in database.json has, so every request returned 404.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends
claims-source-appso it serves both the existing Claims source tutorial and the new Claim sets tutorial on MATTR Learn. Also bumps the Android sample holder to a Holder SDK version that supports claim sets.claims-source-app
GET /claimsnow looks up byrecordIdwhen present. The Claim sets tutorial maps it from the claim set identifier withmapFrom: "claimSetId". Otherwise it looks up bylicenseNumber, as the Claims source tutorial expects.recordIdreturns200 {}instead of404. The Claim sets tutorial's last step issues a record that is not in the database, with the data supplied on the offer. MATTR VII fails issuance on a non-2XX Claims source response, so a404would break that step.emailquery parameter that no record indatabase.jsonhas, so every request returned404. The data and README switched tolicenseNumberin chore: Update Claims Source app #252, but the code was never updated.BC-1001toBC-1003) for one fictional family./guides/oid4vci/claim-source-tutorialURL with the current tutorial URLs. The top-level README's empty tutorial link is filled in.android-holder-tutorial-sample-app
global.mattr.mobilecredential:holderfrom 7.0.1 to 7.2.0. From 7.2.0 the SDK claims several credentials of the same type from one offer, and the Holder SDK quickstart points Claim sets tutorial readers to this app. The 7.1.x and 7.2.0 changelogs list no API changes that affectMainActivity.kt.Testing
licenseNumber=DL-123456returns 200licenseNumberreturns 404recordId=BC-1002returns 200 with the recordrecordId=BC-1004returns 200{}x-api-keyreturns 401Merge order
The Claim sets tutorial link in the READMEs goes live when the companion MATTR Learn PR merges. Merge this PR first, because the tutorial links to the new records.
🤖 Generated with Claude Code