Skip to content

fix(react-native-mdocs-holder-tutorial): repair Android debug build #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avner-m merged 2 commits into from
Sep 14, 2026
Merged

fix(react-native-mdocs-holder-tutorial): repair Android debug build #341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b874e6
fix(react-native-mdocs-holder-tutorial): repair Android debug build
avner-m Sep 14, 2026
e08ea4f
fix(react-native-mdocs-holder-tutorial): apply the same fixes to the …
avner-m Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion react-native-mdocs-holder-tutorial/react-native-mdocs-holder-tutorial-complete/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
"expo": "^55",
"expo-build-properties": "~55.0.13",
"expo-constants": "~55.0.15",
"expo-dev-client": "~55.0.28",
"expo-linking": "~55.0.14",
"expo-router": "~55.0.13",
"expo-web-browser": "~55.0.14",
Expand Down
60 changes: 52 additions & 8 deletions ...mdocs-holder-tutorial/react-native-mdocs-holder-tutorial-complete/withAndroidHolderSDK.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* Expo Config Plugin for MATTR Mobile Credential Holder SDK (Android)
*
* This plugin configures the Android build for the MATTR Mobile Credential Holder SDK.
* It performs three critical tasks:
* It performs four critical tasks:
*
* 1. MAVEN REPOSITORY SETUP
* - Adds the local Maven repository for the MATTR SDK native Android libraries
Expand All @@ -19,6 +19,10 @@
* - Configures it to ONLY handle: appscheme://credentials/callback
* - This activity processes OAuth responses and passes them to the SDK
*
* 4. DEVELOPMENT LAUNCH INTENT FILTER
* - Registers appscheme://expo-development-client on MainActivity
* - Allows `expo run:android` to open the app once it has been installed
*
* WHY THIS IS NEEDED:
* - Without the Maven repo: SDK native libraries won't be found during build
* - Without intent filter cleanup: MainActivity would catch appscheme://credentials/callback,
Expand Down Expand Up @@ -65,6 +69,8 @@ function withAndroidHolderSDK(config) {
const androidManifest = config.modResults;
const application = androidManifest.manifest.application[0];

const appScheme = config.android?.package;

// Find MainActivity and clean up its intent filters
const mainActivity = application.activity?.find(
(activity) => activity.$["android:name"] === ".MainActivity",
Expand All @@ -84,11 +90,7 @@ function withAndroidHolderSDK(config) {

// Remove the app scheme if it doesn't have a host
// This prevents MainActivity from catching all app scheme URLs
if (
scheme ===
"io.mattrlabs.sample.reactnativemobilecredentialholdertutorialapp" &&
!hasHost
) {
if (scheme === appScheme && !hasHost) {
return false;
}

Expand All @@ -115,6 +117,8 @@ function withAndroidHolderSDK(config) {

const application = androidManifest.manifest.application[0];

const appScheme = config.android?.package;

// Check if the activity already exists
const activityExists = application.activity?.some(
(activity) =>
Expand Down Expand Up @@ -155,8 +159,7 @@ function withAndroidHolderSDK(config) {
data: [
{
$: {
"android:scheme":
"io.mattrlabs.sample.reactnativemobilecredentialholdertutorialapp",
"android:scheme": appScheme,
"android:host": "credentials",
"android:pathPrefix": "/callback",
},
Expand All @@ -176,6 +179,47 @@ function withAndroidHolderSDK(config) {
return config;
});

// Register the development launch deep link on MainActivity
config = withAndroidManifest(config, (config) => {
const application = config.modResults.manifest.application[0];
const appScheme = config.android?.package;

const mainActivity = application.activity?.find(
(activity) => activity.$["android:name"] === ".MainActivity",
);

if (!appScheme || !mainActivity) {
return config;
}

const alreadyRegistered = mainActivity["intent-filter"]?.some((filter) =>
filter.data?.some(
(dataNode) => dataNode.$["android:host"] === "expo-development-client",
),
);

if (!alreadyRegistered) {
mainActivity["intent-filter"] = mainActivity["intent-filter"] ?? [];
mainActivity["intent-filter"].push({
action: [{ $: { "android:name": "android.intent.action.VIEW" } }],
category: [
{ $: { "android:name": "android.intent.category.DEFAULT" } },
{ $: { "android:name": "android.intent.category.BROWSABLE" } },
],
data: [
{
$: {
"android:scheme": appScheme,
"android:host": "expo-development-client",
},
},
],
});
}

return config;
});

return config;
}

Expand Down
57 changes: 4 additions & 53 deletions react-native-mdocs-holder-tutorial/react-native-mdocs-holder-tutorial-complete/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1348,10 +1348,10 @@
"@jridgewell/resolve-uri" "^3.1.0"
"@jridgewell/sourcemap-codec" "^1.4.14"

"@mattrglobal/mobile-credential-holder-react-native@^8.1.1":
version "8.1.2"
resolved "https://registry.yarnpkg.com/@mattrglobal/mobile-credential-holder-react-native/-/mobile-credential-holder-react-native-8.1.2.tgz#6c9f0ed338c5d7fe0479a3d115680930bcf31c44"
integrity sha512-TzUH9CmBsy5PBDOuyMFT0lKAfkgrpI2ByDgZib4MCZohxmp9UnpqNmfOyfj1Z7dn2PX+Xbh+Lqcdz0Pf8cC13w==
"@mattrglobal/mobile-credential-holder-react-native@^10.0.0":
version "10.0.0"
resolved "https://registry.yarnpkg.com/@mattrglobal/mobile-credential-holder-react-native/-/mobile-credential-holder-react-native-10.0.0.tgz#7dff65f9728c1d840c5f35d8f3fad4534be4103d"
integrity sha512-phN0/6mC1gWf6NZnOs1UBHxhYK+hc94sWELikueJ1/hyvH7h65iVBTweLRAFl5fBXzJYNldCWZoS/WRk5LNAUQ==
dependencies:
neverthrow "4.3.0"
zod "3.22.3"
Expand Down Expand Up @@ -2726,38 +2726,6 @@ expo-constants@~55.0.15:
dependencies:
"@expo/env" "~2.1.1"

expo-dev-client@~55.0.28:
version "55.0.28"
resolved "https://registry.yarnpkg.com/expo-dev-client/-/expo-dev-client-55.0.28.tgz#0189f72ebb6540f668e62f65d8e4a49b596570e9"
integrity sha512-QZK6Ylx8Jg7lhOOHCxwC10g+i34ggMBAqV497JXFqla1tuuYiEw1poNJS5pD/60ZLe8kyy5PYPB4E9ezDHA9yQ==
dependencies:
expo-dev-launcher "55.0.29"
expo-dev-menu "55.0.24"
expo-dev-menu-interface "55.0.2"
expo-manifests "~55.0.16"
expo-updates-interface "~55.1.6"

[email protected]:
version "55.0.29"
resolved "https://registry.yarnpkg.com/expo-dev-launcher/-/expo-dev-launcher-55.0.29.tgz#3a791e5cf5e95209fd8665ee928d5c635abc3a80"
integrity sha512-Rusz6VfVUAXPArkQhnxC5yY70RCfGNZv+06qCGIkm2boQ3wOiSUwJic8oIt7kW6yD2rkpm24q/7F/6r5joPfng==
dependencies:
"@expo/schema-utils" "^55.0.3"
expo-dev-menu "55.0.24"
expo-manifests "~55.0.16"

[email protected]:
version "55.0.2"
resolved "https://registry.yarnpkg.com/expo-dev-menu-interface/-/expo-dev-menu-interface-55.0.2.tgz#aead1b9980c904d61c59e9182e13b2b37bcb2161"
integrity sha512-DomUNvGzY/xliwnMdbAYY780sCv19N7zIbifc0ClcoCzJZpNSCkvJ2qGIFRPyM/7DmqmlHGCKi8di7kYYLKNEg==

[email protected]:
version "55.0.24"
resolved "https://registry.yarnpkg.com/expo-dev-menu/-/expo-dev-menu-55.0.24.tgz#6af52133cd9de105d28317eb47938ffedb041e3b"
integrity sha512-/J93rADODlKpmaN9uywTd/RMywPDeUo/bAnrZNxlHrFUuO1VCGqYLhacITg2zebU8hucaou8pa8zVsTQaUCv6w==
dependencies:
expo-dev-menu-interface "55.0.2"

expo-file-system@~55.0.17:
version "55.0.17"
resolved "https://registry.yarnpkg.com/expo-file-system/-/expo-file-system-55.0.17.tgz#81e4bc15773ed0c0098edd26a8c2d31f3844219d"
Expand All @@ -2782,11 +2750,6 @@ expo-image@^55.0.9:
dependencies:
sf-symbols-typescript "^2.2.0"

expo-json-utils@~55.0.2:
version "55.0.2"
resolved "https://registry.yarnpkg.com/expo-json-utils/-/expo-json-utils-55.0.2.tgz#ef79888b881ef5b92d27245d3a758bc5debcbccf"
integrity sha512-QJMOZOPOG7CTnKcrdVaiummn2va1MCO56z++eyWkDv3GBRODldM6MFMDf/jTREWthFc2Nxo6TuyWRrEV9S6n/Q==

expo-keep-awake@~55.0.6:
version "55.0.6"
resolved "https://registry.yarnpkg.com/expo-keep-awake/-/expo-keep-awake-55.0.6.tgz#b5bac9a811e0dfe77deefeaf57e9c73b5dbcc839"
Expand All @@ -2800,13 +2763,6 @@ expo-linking@~55.0.14:
expo-constants "~55.0.15"
invariant "^2.2.4"

expo-manifests@~55.0.16:
version "55.0.16"
resolved "https://registry.yarnpkg.com/expo-manifests/-/expo-manifests-55.0.16.tgz#d10c4f259561d37bc2bd1ef3047d8ab8482c915b"
integrity sha512-BR9BPcNsSnCKlQ/d7ECywr+2T54+bTSr26HjRjSua949o4mO/iPIrLjK0lOAa1oIczju6a6oUFckZD2OljxP0g==
dependencies:
expo-json-utils "~55.0.2"

[email protected]:
version "55.0.18"
resolved "https://registry.yarnpkg.com/expo-modules-autolinking/-/expo-modules-autolinking-55.0.18.tgz#a360b9d0fc0afb4cfba22233c67780f01cba6053"
Expand Down Expand Up @@ -2869,11 +2825,6 @@ expo-symbols@^55.0.7:
"@expo-google-fonts/material-symbols" "^0.4.1"
sf-symbols-typescript "^2.0.0"

expo-updates-interface@~55.1.6:
version "55.1.6"
resolved "https://registry.yarnpkg.com/expo-updates-interface/-/expo-updates-interface-55.1.6.tgz#18a806d65a28229ed4a7f920fceb9dda678c5c09"
integrity sha512-evxNpagCkjT3lE6bGV570TFzRtKuIuLY8I37RYHoriXCJ+ZKCN1hbmklK29uAixya+BxGpeTI2K4FqYeJLvfrw==

expo-web-browser@~55.0.14:
version "55.0.14"
resolved "https://registry.yarnpkg.com/expo-web-browser/-/expo-web-browser-55.0.14.tgz#ce58dcf8103123fd4e812d6909e390255ee6373b"
Expand Down
1 change: 0 additions & 1 deletion react-native-mdocs-holder-tutorial/react-native-mdocs-holder-tutorial-starter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
"expo": "^55",
"expo-build-properties": "~55.0.13",
"expo-constants": "~55.0.15",
"expo-dev-client": "~55.0.28",
"expo-linking": "~55.0.14",
"expo-router": "~55.0.13",
"expo-web-browser": "~55.0.14",
Expand Down
60 changes: 52 additions & 8 deletions ...-mdocs-holder-tutorial/react-native-mdocs-holder-tutorial-starter/withAndroidHolderSDK.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* Expo Config Plugin for MATTR Mobile Credential Holder SDK (Android)
*
* This plugin configures the Android build for the MATTR Mobile Credential Holder SDK.
* It performs three critical tasks:
* It performs four critical tasks:
*
* 1. MAVEN REPOSITORY SETUP
* - Adds the local Maven repository for the MATTR SDK native Android libraries
Expand All @@ -19,6 +19,10 @@
* - Configures it to ONLY handle: appscheme://credentials/callback
* - This activity processes OAuth responses and passes them to the SDK
*
* 4. DEVELOPMENT LAUNCH INTENT FILTER
* - Registers appscheme://expo-development-client on MainActivity
* - Allows `expo run:android` to open the app once it has been installed
*
* WHY THIS IS NEEDED:
* - Without the Maven repo: SDK native libraries won't be found during build
* - Without intent filter cleanup: MainActivity would catch appscheme://credentials/callback,
Expand Down Expand Up @@ -65,6 +69,8 @@ function withAndroidHolderSDK(config) {
const androidManifest = config.modResults;
const application = androidManifest.manifest.application[0];

const appScheme = config.android?.package;

// Find MainActivity and clean up its intent filters
const mainActivity = application.activity?.find(
(activity) => activity.$["android:name"] === ".MainActivity",
Expand All @@ -84,11 +90,7 @@ function withAndroidHolderSDK(config) {

// Remove the app scheme if it doesn't have a host
// This prevents MainActivity from catching all app scheme URLs
if (
scheme ===
"io.mattrlabs.sample.reactnativemobilecredentialholdertutorialapp" &&
!hasHost
) {
if (scheme === appScheme && !hasHost) {
return false;
}

Expand All @@ -115,6 +117,8 @@ function withAndroidHolderSDK(config) {

const application = androidManifest.manifest.application[0];

const appScheme = config.android?.package;

// Check if the activity already exists
const activityExists = application.activity?.some(
(activity) =>
Expand Down Expand Up @@ -155,8 +159,7 @@ function withAndroidHolderSDK(config) {
data: [
{
$: {
"android:scheme":
"io.mattrlabs.sample.reactnativemobilecredentialholdertutorialapp",
"android:scheme": appScheme,
"android:host": "credentials",
"android:pathPrefix": "/callback",
},
Expand All @@ -176,6 +179,47 @@ function withAndroidHolderSDK(config) {
return config;
});

// Register the development launch deep link on MainActivity
config = withAndroidManifest(config, (config) => {
const application = config.modResults.manifest.application[0];
const appScheme = config.android?.package;

const mainActivity = application.activity?.find(
(activity) => activity.$["android:name"] === ".MainActivity",
);

if (!appScheme || !mainActivity) {
return config;
}

const alreadyRegistered = mainActivity["intent-filter"]?.some((filter) =>
filter.data?.some(
(dataNode) => dataNode.$["android:host"] === "expo-development-client",
),
);

if (!alreadyRegistered) {
mainActivity["intent-filter"] = mainActivity["intent-filter"] ?? [];
mainActivity["intent-filter"].push({
action: [{ $: { "android:name": "android.intent.action.VIEW" } }],
category: [
{ $: { "android:name": "android.intent.category.DEFAULT" } },
{ $: { "android:name": "android.intent.category.BROWSABLE" } },
],
data: [
{
$: {
"android:scheme": appScheme,
"android:host": "expo-development-client",
},
},
],
});
}

return config;
});

return config;
}

Expand Down
Loading
Loading