Skip to content

remove broken remnants of Python 2 compatibility - #272

Open
a-detiste wants to merge 1 commit into
matthewwithanm:developfrom
a-detiste:develop
Open

remove broken remnants of Python 2 compatibility#272
a-detiste wants to merge 1 commit into
matthewwithanm:developfrom
a-detiste:develop

Conversation

@a-detiste

Copy link
Copy Markdown

by using typing, which is a good thing,
this project cannot be Python2-compatible anymore;
this cleans this up

$ grep Union -r
markdownify/__init__.pyi:from typing import Callable, Union
markdownify/__init__.pyi:    code_language_callback: Union[Callable[[Incomplete], Union[str, None]], None] = ...,
markdownify/__init__.pyi:    convert: Union[list[str], None] = ...,
markdownify/__init__.pyi:    strip: Union[list[str], None] = ...,
markdownify/__init__.pyi:    strip_document: Union[str, None] = ...,
markdownify/__init__.pyi:    strip_pre: Union[str, None] = ...,
markdownify/__init__.pyi:    wrap_width: Union[int, None] = ...,
markdownify/__init__.pyi:        code_language_callback: Union[Callable[[Incomplete], Union[str, None]], None] = ...,
markdownify/__init__.pyi:        convert: Union[list[str], None] = ...,
markdownify/__init__.pyi:        strip: Union[list[str], None] = ...,
markdownify/__init__.pyi:        strip_document: Union[str, None] = ...,
markdownify/__init__.pyi:        strip_pre: Union[str, None] = ...,
markdownify/__init__.pyi:        wrap_width: Union[int, None] = ...,
tests/types.py:from typing import Union
tests/types.py:def callback(el: BeautifulSoup) -> Union[str, None]:

by using typing, which is a _good_ thing,
this project cannot be Python2-compatible anymor

$ grep Union -r
markdownify/__init__.pyi:from typing import Callable, Union
markdownify/__init__.pyi:    code_language_callback: Union[Callable[[Incomplete], Union[str, None]], None] = ...,
markdownify/__init__.pyi:    convert: Union[list[str], None] = ...,
markdownify/__init__.pyi:    strip: Union[list[str], None] = ...,
markdownify/__init__.pyi:    strip_document: Union[str, None] = ...,
markdownify/__init__.pyi:    strip_pre: Union[str, None] = ...,
markdownify/__init__.pyi:    wrap_width: Union[int, None] = ...,
markdownify/__init__.pyi:        code_language_callback: Union[Callable[[Incomplete], Union[str, None]], None] = ...,
markdownify/__init__.pyi:        convert: Union[list[str], None] = ...,
markdownify/__init__.pyi:        strip: Union[list[str], None] = ...,
markdownify/__init__.pyi:        strip_document: Union[str, None] = ...,
markdownify/__init__.pyi:        strip_pre: Union[str, None] = ...,
markdownify/__init__.pyi:        wrap_width: Union[int, None] = ...,
tests/types.py:from typing import Union
tests/types.py:def callback(el: BeautifulSoup) -> Union[str, None]:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant