Repository navigation
Show error messages in full, under the file name - #17
Merged
Merged
Conversation
The Status column only has room for a word, so on a phone the HEIC message was cut to "This bro…", and its title tooltip can't be opened by touch. Status now says "Failed" and the message wraps under the file name. The HEIC message also says what to do. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01STHRjFYWhkJBxSKG3tJdap
Deploying image-optimizer with
|
| Latest commit: |
4774e5b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4f852f38.image-optimizer-7ba.pages.dev |
| Branch Preview URL: | https://fix-error-text.image-optimizer-7ba.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found on a real Android phone (Pixel 7 Pro, Chrome). Adding a HEIC file showed the right error, but cut short. At phone width the Status column showed "This bro…". Even the desktop-site view only got as far as "This browser can't..". The full text was in a
titletooltip, which touch can't open.Change
At 412 px wide (the Pixel 7 Pro's width), it wraps over four lines under the name; on desktop it fits on one.
Tests
e2e/decode.spec.ts: the HEIC test runs at 412 px wide. It checks the whole message is visible and not clipped, and that Status reads "Failed".e2e/a11y.spec.ts: the axe run now includes a failed row, so the red message is checked for contrast in light and dark mode.Independent of #16; both target
stagingand merge cleanly together.🤖 Generated with Claude Code
https://claude.ai/code/session_01STHRjFYWhkJBxSKG3tJdap